After doing a quick review, I see that there are some coding standards error.

And most importantly the file video_embed_damdy.permissions is wrongly named. the extensions is missing.

CommentFileSizeAuthor
#4 video_embed_damdy-fix_cs-3090470-4.patch9.31 KBgrimreaper
#3 video_embed_damdy-fix_cs-3090470-3.patch9.11 KBgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Version: 8.x-1.0-beta3 » 8.x-1.x-dev

8.x-1.0 version was not appearing.

And I have made the dev version available.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » phjou
Status: Active » Needs review
StatusFileSize
new video_embed_damdy-fix_cs-3090470-3.patch9.11 KB

Hi,

Here is the patch.

@phjou can you give a review please?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
StatusFileSize
new video_embed_damdy-fix_cs-3090470-4.patch9.31 KB

Project page updated.

Readme slightly changed to reflect that.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented

The patch looks good to me.

  • Grimreaper authored 596f17a on 8.x-1.x 
    Issue #3090470 by Grimreaper: Fix CS and permission file
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: phjou » Unassigned
Status: Needs review » Fixed

Thanks for the review.

It has been merged.

Sorry, I merged my commit and forgot to remake it to mention you in the commit message.

But you will be credited through the issue.

I will make a new release.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented

Just noticed a little error that popup in the drupal standards now:
https://pareview.sh/pareview/https-git.drupal.org-project-video_embed_damdy

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Thanks.

Done in #3090598: Add composer.json.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue tags: +DrupalCon Amsterdam 2019
rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Issue tags: -DrupalCon Amsterdam 2019 +Amsterdam2019

retagging

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.