php drupal-check.phar modules/contrib/open_readspeaker/
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------- 
  Line   src/Plugin/Block/OpenReadspeakerBlock.php          
 ------ --------------------------------------------------- 
  121    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 1 error
CommentFileSizeAuthor
#5 deprecated-3090082-5.patch1.2 KBsunlix
#2 deprecated-3090082-2.patch807 bytessergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3090082-2.patch807 bytes

Here is the patch, please review.

sunlix’s picture

sunlix
Primary language English
Location Wesel
commented

@Sergiu Stici

Thank you for reporting and providing the patch.
I think as of the current coding style guidelines we should switch to shorthand array syntax.

Switch from array() to []

I think multi-line array for placeholder are a little bit handier to read.

$this->messenger()->addMessage($this->t('Please go to @link and fill the account id.', [
  '@link' => l($this->t('manage open ReadSpeaker'), 'admin/config/services/open-readspeaker'),
]));
sunlix’s picture

sunlix
Primary language English
Location Wesel
commented

@Sergiu Stici

the l() function on this line is also deprecated due to change record: https://www.drupal.org/node/2346779

sunlix’s picture

sunlix
Primary language English
Location Wesel
commented
StatusFileSize
new deprecated-3090082-5.patch1.2 KB

  • sunlix committed f8df232 on 8.x-1.x 
    Issue #3090082 by Sergiu Stici, sunlix: Deprecated Code Report
sunlix’s picture

sunlix
Primary language English
Location Wesel
commented
Status: Needs review » Fixed
sunlix’s picture

sunlix
Primary language English
Location Wesel
commented
Related issues: +#2920724: Call to undefined function

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.