This module is an integration with the splio email platform (https://www.splio.com/) and allow to map and synchronize entities and his fields.

Project link

https://www.drupal.org/project/splio

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/splio.git

PAReview

https://pareview.sh/pareview/https-git.drupal.org-project-splio.git

Comments

estoyausente created an issue. See original summary.

estoyausente’s picture

estoyausente
Primary language Spanish
commented
Status: Active » Needs review
phthlaap’s picture

phthlaap commented

Please change default branch to 8.x-1.x

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

Thank you for applying! For these applications, we need a project/branch where you committed most of the code, if not all. In this case, there are more commits from other users.

Since the purpose of these applications is verifying what the user who applies understands about writing secure code that correctly uses the Drupal APIs and follow the Drupal coding standards, we cannot review code written from more users to understand what a single user understands of writing Drupal code.

estoyausente’s picture

estoyausente
Primary language Spanish
commented

Hi, @kiamlaluno! Thanks for answering. The module is developed by my mate @miguelarber. I just posted the project here because I have more experience developing Drupal and I did a review of his code and manage the project publication. But don't worry! My mate will post here and you can review the code with him :)

miguelarber’s picture

miguelarber commented

Hi all!

I will be happy to answer any inquiry you might have related to the Splio module. At this moment, my commits in Drupal.org appear as 'unattributed', however I have already created an issue to see if you can solve this situation.

Meanwhile, you can check all the authoring information in the Drupal code repository. I've also changed the default branch to 8.x-1.x. Thanks.

miguelarber’s picture

miguelarber commented
Status: Needs work » Needs review
phthlaap’s picture

phthlaap commented
Issue summary: View changes
Status: Needs review » Needs work

Thanks for your contribution.

Please fix some issues reported by PAReview:

Git errors:
There is still a master branch, make sure to set the correct default branch: https://www.drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in https://www.drupal.org/node/1127732
Review of the 8.x-1.x branch (commit c1a2f61):
Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing.
PHP Parse error: syntax error, unexpected ')' in ./tests/src/Unit/SplioConnectorTest.php on line 103 Errors parsing ./tests/src/Unit/SplioConnectorTest.php
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
DrupalPractice has found some issues with your code, but could be false positives.

FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/splio.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 7 | WARNING | All dependencies must be prefixed with the project name,
   |         | for example "drupal:"
--------------------------------------------------------------------------


FILE: ...al/pareviewsh/pareview_temp/modules/splio_utils/splio_utils.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 6 | WARNING | All dependencies must be prefixed with the project name,
   |         | for example "drupal:"
 7 | WARNING | All dependencies must be prefixed with the project name,
   |         | for example "drupal:"
--------------------------------------------------------------------------


FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Services/SplioConnector.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 431 | WARNING | Unused variable $keyFields.
 941 | WARNING | Unused variable $fieldKey.
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/Form/SplioFieldForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 523 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 559 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 609 | WARNING | Unused variable $splio_list.
 609 | WARNING | Unused variable $drupal_list_field.
--------------------------------------------------------------------------


FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Form/EntitiesConfigForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
 224 | WARNING | Variable $bundles is undefined.
 328 | WARNING | Variable $bundles is undefined.
 328 | WARNING | Variable $bundles is undefined.
 331 | WARNING | Variable $bundles is undefined.
 333 | WARNING | Variable $bundles is undefined.
 344 | WARNING | Variable $bundles is undefined.
--------------------------------------------------------------------------

Time: 3.84 secs; Memory: 10Mb
FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/splio.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 1 ERROR AND 38 WARNINGS AFFECTING 38 LINES
--------------------------------------------------------------------------
  1 | WARNING | [ ] Line exceeds 80 characters; contains 173 characters
  2 | WARNING | [ ] Line exceeds 80 characters; contains 145 characters
  3 | WARNING | [ ] Line exceeds 80 characters; contains 152 characters
  4 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
  5 | WARNING | [ ] Line exceeds 80 characters; contains 175 characters
 10 | WARNING | [ ] Line exceeds 80 characters; contains 114 characters
 11 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
 12 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 13 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
 14 | WARNING | [ ] Line exceeds 80 characters; contains 142 characters
 15 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters
 19 | WARNING | [ ] Line exceeds 80 characters; contains 180 characters
 20 | WARNING | [ ] Line exceeds 80 characters; contains 195 characters
 25 | WARNING | [ ] Line exceeds 80 characters; contains 134 characters
 29 | WARNING | [ ] Line exceeds 80 characters; contains 197 characters
 37 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 38 | WARNING | [ ] Line exceeds 80 characters; contains 152 characters
 40 | WARNING | [ ] Line exceeds 80 characters; contains 189 characters
 41 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
 45 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
 47 | WARNING | [ ] Line exceeds 80 characters; contains 177 characters
 48 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters
 50 | WARNING | [ ] Line exceeds 80 characters; contains 146 characters
 51 | WARNING | [ ] Line exceeds 80 characters; contains 200 characters
 52 | WARNING | [ ] Line exceeds 80 characters; contains 175 characters
 54 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
 56 | WARNING | [ ] Line exceeds 80 characters; contains 199 characters
 57 | WARNING | [ ] Line exceeds 80 characters; contains 187 characters
 61 | WARNING | [ ] Line exceeds 80 characters; contains 207 characters
 66 | WARNING | [ ] Line exceeds 80 characters; contains 210 characters
 67 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 69 | WARNING | [ ] Line exceeds 80 characters; contains 158 characters
 71 | WARNING | [ ] Line exceeds 80 characters; contains 163 characters
 73 | WARNING | [ ] Line exceeds 80 characters; contains 200 characters
 77 | WARNING | [ ] Line exceeds 80 characters; contains 200 characters
 80 | WARNING | [ ] Line exceeds 80 characters; contains 221 characters
 82 | WARNING | [ ] Line exceeds 80 characters; contains 177 characters
 84 | WARNING | [ ] Line exceeds 80 characters; contains 155 characters
 84 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...review_temp/modules/splio_utils/src/Services/SplioTriggerManager.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 34 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...al/pareviewsh/pareview_temp/modules/splio_utils/splio_utils.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: ...000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/splio.module
--------------------------------------------------------------------------
FOUND 10 ERRORS AND 6 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
  9 | WARNING | [ ] Hook implementations should not duplicate @param
    |         |     documentation
  9 | ERROR   | [ ] Missing parameter comment
  9 | ERROR   | [ ] Missing parameter type
 10 | WARNING | [ ] Hook implementations should not duplicate @param
    |         |     documentation
 10 | ERROR   | [ ] Missing parameter comment
 10 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 12 | WARNING | [ ] Hook implementations should not duplicate @return
    |         |     documentation
 12 | ERROR   | [ ] Description for the @return value is missing
 13 | ERROR   | [x] There must be no blank lines after the function
    |         |     comment
 33 | WARNING | [ ] Hook implementations should not duplicate @param
    |         |     documentation
 33 | ERROR   | [ ] Missing parameter comment
 47 | WARNING | [ ] Hook implementations should not duplicate @param
    |         |     documentation
 47 | ERROR   | [ ] Missing parameter comment
 61 | WARNING | [ ] Hook implementations should not duplicate @param
    |         |     documentation
 61 | ERROR   | [ ] Missing parameter comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/Entity/SplioEntity.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 18 | ERROR | [ ] Inline doc block comments are not allowed; use "/*
    |       |     Comment */" or "// Comment" instead
 63 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Services/SplioConnector.php
--------------------------------------------------------------------------
FOUND 31 ERRORS AND 2 WARNINGS AFFECTING 31 LINES
--------------------------------------------------------------------------
  201 | ERROR   | [x] Expected newline after closing brace
  257 | ERROR   | [x] Expected newline after closing brace
 1116 | ERROR   | [x] Functions must not contain multiple empty lines in
      |         |     a row; found 2 empty lines
 1191 | ERROR   | [x] Expected newline after closing brace
 1359 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     10
 1360 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     12
 1361 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     12
 1363 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     10
 1365 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     10
 1366 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     10
 1367 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     10
 1368 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     12
 1369 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     14
 1370 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters
 1370 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     14
 1372 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     12
 1373 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     14
 1374 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     16
 1375 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     16
 1376 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     12
 1377 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     10
 1378 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     12
 1379 | WARNING | [ ] Line exceeds 80 characters; contains 131 characters
 1379 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     14
 1380 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     16
 1381 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     18
 1382 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     18
 1383 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     16
 1384 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     10
 1387 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     10
 1388 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     12
 1389 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
      |         |     10
 1391 | ERROR   | [x] Line indented incorrectly; expected 9 spaces, found
      |         |     8
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 31 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...viewsh/pareview_temp/src/Plugin/QueueWorker/SplioQueueController.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 11 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/Form/SplioFieldForm.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
 48 | ERROR | [x] Short array syntax must be used to define arrays
 55 | ERROR | [x] Short array syntax must be used to define arrays
 62 | ERROR | [x] Short array syntax must be used to define arrays
 69 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Form/EntitiesConfigForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 172 | ERROR | [x] Functions must not contain multiple empty lines in a
     |       |     row; found 2 empty lines
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/tests/src/Unit/SplioConnectorTest.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
  14 | ERROR | [ ] Missing short description in doc comment
 204 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 7.5 secs; Memory: 12Mb
miguelarber’s picture

miguelarber commented

Thanks for your comments and revision phthlaap & kiamlaluno. I followed the steps above and the project is ready to be reviewed again. I will be happy to solve any other issue you may detect.

miguelarber’s picture

miguelarber commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I know the other commits are from Miguel Arber. The commit pages don't link to the user profile because the email address used for the commits isn't associated with the user profile, but on https://www.drupal.org/node/3089649/commits appears Miguel Arber Magjistari or Miguel Arber.

Miguel Arber can continue the application, since he doesn't have the vetted role.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

miguelarber’s picture

miguelarber commented

Thanks for updating my account @kiamlaluno. I will be happy to contribute as much as I can!

Thanks for the tips too, I will be reading them carefully in my spare time.

See you guys around!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.