A number of classes and services related to TempStore were moved out of the core user module and into the core framework. This occurred in the Drupal 8.5.x release. We should update our namespaces for these classes and services so they use the current core location and naming.

Change notices:
\Drupal\user\SharedTempStoreFactory is scheduled for removal in Drupal 9.0.0. Use \Drupal\Core\TempStore\SharedTempStoreFactory instead
\Drupal\user\SharedTempStore is scheduled for removal in Drupal 9.0.0. Use \Drupal\Core\TempStore\SharedTempStore instead

CommentFileSizeAuthor
#2 3089549-2-temp-store.patch2.65 KBtr

Comments

TR created an issue. See original summary.

tr’s picture

Status: Active » Needs review
StatusFileSize
new2.65 KB
jonathan1055’s picture

Status: Needs review » Reviewed & tested by the community

Previously at core 8.8 we had deprecation messages

114x: \Drupal\user\SharedTempStore is scheduled for removal in Drupal 9.0.0. Use \Drupal\Core\TempStore\SharedTempStore instead. See https://www.drupal.org/node/2935639.

and
114x: \Drupal\user\SharedTempStore is scheduled for removal in Drupal 9.0.0. Use \Drupal\Core\TempStore\SharedTempStore instead. See https://www.drupal.org/node/2935639.
and the total number of deprecations reported on the Travis build was 12,309.

I have just tested this patch on Travis and the two lots of 114x messages above are no longer shown. The total number of deprecations reported is 12,081 which is 12,309 - 2x114. Just to be sure, I checked the rest of the list of deprecations and they all match the list as on #3089502: [meta] Rules deprecated code

I have marked this RTBC but not sure if there is anything else we need to test manually?

  • TR committed 4163f06 on 8.x-3.x
    Issue #3089549 by TR: Fix TempStore deprecations
    
tr’s picture

Status: Reviewed & tested by the community » Fixed

Committed. No test needed - it's really just a change of namespace.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

Adding parent

jonathan1055’s picture