In MigrationPluginManager.php line 104:

The disqus_enabled_content_types plugin must define the source_module property.

Will also fix the count() not inheriting the refresh parameter.

Also rolled the fix for:
https://www.drupal.org/project/disqus/issues/3089234

CommentFileSizeAuthor
#3 3089452-03.patch3.33 KBki
#2 3089452-02.patch3.84 KBspfaffly

Comments

spfaffly created an issue. See original summary.

spfaffly’s picture

spfaffly commented
Issue summary: View changes
Related issues: +#3089234: Error: Cannot use object of type stdClass as array
StatusFileSize
new 3089452-02.patch3.84 KB
ki’s picture

ki commented
StatusFileSize
new 3089452-03.patch3.33 KB

#2 patch did not work on 8.x-1.0, which partially includes the patch. This patch works for 8.x-1.0.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
bonfil1’s picture

bonfil1 commented

I just sent a MR, hoping it gets approved, teste in D9, the issue: https://www.drupal.org/project/disqus/issues/3222241
https://git.drupalcode.org/project/disqus/-/merge_requests/2

  • Ki authored 98b8c17 on 8.x-1.x 
    Issue #3089452 by spfaffly, Ki: In MigrationPluginManager.php line 104...
gaurav.kapoor’s picture

gaurav.kapoor commented

Thanks for working on migration related issues in the Disqus module. I believe the code provided by the patch and the MR are already in D8 Development release. Check if you are still getting error.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.