Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
21 Oct 2019 at 11:12 UTC
Updated:
18 Nov 2019 at 05:44 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoThank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.
If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.
Comment #3
dipali.goel25 commentedI have made the changes
but still https://pareview.sh/pareview/https-git.drupal.org-project-menu_title_len...
gives the old error .
Comment #4
avpadernoIt will show the last review, until Repeat review is clicked. Reviews aren't automatically repeated when the page is visited.
Comment #5
dipali.goel25 commentedI did same , I clicked n repeat review , still its showing the review of old tag .
Comment #6
avpadernoIt reviews just the branches with the correct name. menu_title_link is not a correct branch name, and it should be removed. 8.x-1.x is a correct branch name.
Comment #7
dipali.goel25 commentedComment #8
dipali.goel25 commentedAll the "PAReview: single application approval" is done
kindly have look at
https://pareview.sh/pareview/https-git.drupal.org-project-menu_title_len...
Comment #9
phthlaap commentedThanks for your contribution. I don't find any security issues related to the code.
Comment #10
dipali.goel25 commentedThanks Lap Pham for reviewing .
Kindly let me know what else I needed to do so that my project comes under stable version.
as now tag is " Reviewed & tested by the community" .
Comment #11
avpadernoThank you for your contribution! I am going to update the project to opt it into security coverage.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #12
dipali.goel25 commentedThanks for helping me to make my module stable