\Drupal\views\Plugin\views\field\Field was deprecated in #2408667: Rename Field.php to EntityField.php before the core deprecation policy was enforced. It does not @trigger_error a deprecation notice.

CommentFileSizeAuthor
#2 3089103-2.patch1.82 KBkim.pepper

Comments

kim.pepper created an issue. See original summary.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review
Related issues: +#2408667: Rename Field.php to EntityField.php
StatusFileSize
new 3089103-2.patch1.82 KB

Here's a patch that adds the trigger error. Also added a change record.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Thanks, for the patch and creating the issue.

+++ b/core/modules/views/src/Plugin/views/field/Field.php
@@ -2,12 +2,30 @@
+    @trigger_error(__CLASS__ . ' is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use \Drupal\views\Plugin\views\field\EntityField instead. See https://www.drupal.org/node/3089106', E_USER_DEPRECATED);

s/8.8.0/8.3.0? Can be fixed on commit if required.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.0.x and cherry-picked to 8.9.x and 8.8.x, fixed the deprecation version on commit.

  • catch committed 735c978 on 9.0.x 
    Issue #3089103 by kim.pepper, jibran: Properly deprecate \Drupal\views\...
catch’s picture

catch
he/him
Primary language English
commented

  • catch committed c1d12b8 on 8.9.x 
    Issue #3089103 by kim.pepper, jibran: Properly deprecate \Drupal\views\...

  • catch committed 012438a on 8.8.x 
    Issue #3089103 by kim.pepper, jibran: Properly deprecate \Drupal\views\...
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Published the change record.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.