Instead of creating 3 forms elements depending on filter type .Trait can be used to optimise code.

CommentFileSizeAuthor
#7 vcr-node_optimization-3089094-7.patch7.42 KBasmita26
#2 vcr-code_optimization-3089094-2-8.7.8.patch5.7 KBasmita26

Comments

asmita26 created an issue. See original summary.

asmita26’s picture

asmita26 commented
StatusFileSize
new vcr-code_optimization-3089094-2-8.7.8.patch5.7 KB

Code is optimised using traits for Combined-filter & String-filter Plugins. Which contains function for creating regular-expression & building-form.

asmita26’s picture

asmita26 commented
Assigned: asmita26 » Unassigned
Status: Active » Needs review
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented

@asmita26 RegularExpressionTrait is missing. Please update the patch.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Status: Needs review » Needs work
asmita26’s picture

asmita26 commented
Assigned: Unassigned » asmita26
Status: Needs work » Active
asmita26’s picture

asmita26 commented
Assigned: asmita26 » Unassigned
Status: Active » Needs review
StatusFileSize
new vcr-node_optimization-3089094-7.patch7.42 KB

Please consider the latest patch which contains RegularExpressionTrait.php

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Version: 8.x-1.0-alpha1 » 8.x-1.x-dev
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Version: 8.x-1.x-dev » 8.x-1.0-alpha1
Status: Needs review » Fixed

  • pratik_kamble committed a49d5d3 on 8.x-1.x authored by asmita26 
    Issue #3089094 by asmita26, pratik_kamble: Optimise common code by using...

  • pratik_kamble committed 5146166 on 8.x-1.x 
    Revert "Issue #3089094 by asmita26, pratik_kamble: Optimise common code...
  • pratik_kamble committed bebac90 on 8.x-1.x authored by asmita26
    Issue #3089094 by asmita26, pratik_kamble: Optimise common code by using...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.