From @saschaeggi in #3088378: Designs for new front-end theme for Drupal 9

We should investigate further improvements to the Drupal's messages.

Two things we learned over at what we're working on for Claro is that buttons and messages can be quite controversial. Maybe you can profit from the research and iterations we run through for messages styles until we landed at the current design implementation (find the specs here: https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Drupal-Design-system...). The synergies could be used to port it over to Olivero. Also for the focus styles we did a lot of feedback loops also with the accessibility team until we landed at the current implementation, see #3028099: Element focus: accessibility review and #3021087: Buttons.

CommentFileSizeAuthor
#4 Messages (Desktop) (1).jpg764.51 KBmherchel

Comments

mherchel created an issue. See original summary.

mherchel’s picture

Issue summary: View changes

mherchel’s picture

Assigned: Unassigned » jwitkowski79
Status: Active » Needs review
StatusFileSize
new764.51 KB

@jwitkowski just updated the figma designs with these messages, which look very similar to Claro's messages.

Messages styles

fhaeberle’s picture

They are looking really good! In my humble opinion we could add some more spacing inside the message, but it's already really nice! Are the colors used within the message (icons) tested in case of contrast ratio?

mherchel’s picture

Issue tags: +Accessibility
jwitkowski79’s picture

@fhaeberle Thanks! The contrast ratio has been tested and it passes with the following ratios:
red: 4.48
yellow: 12.29
green: 5.74
gray close button: 6.11

mherchel’s picture

Status: Needs review » Fixed

These messages are good per today's accessibility meeting with @andrewmacpherson and @rainbreaw with the caveat that the the explanation point within the warning should be transparent (to black) instead of white.

markconroy’s picture

Status: Fixed » Needs review

I think these look great. One (tiny, tiny, tiny) gripe I might have is that the white-on-yellow warning one, I find the white hard to see because it doesn't contrast much with the yellow. Perhaps we could make that white to be the same dark grey/black like we have for the red and green icons.

Besides that, great work.

markconroy’s picture

Status: Needs review » Fixed

Sorry, we got cross-mojo when we were both adding comments at the same time @mherchel

Back to 'fixed'

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.