I have wanted to do this for a very long time. Since Drupal 8.3, actually.

The "cckfield" plugin type, defined by the Migrate Drupal module, was superseded by the "field" plugin type. Grafting a backwards compatibility layer onto this monumentally poorly named plugin type was hell and I'm pretty sure it almost drove @quietone insane. So it is going to be tremendously satisfying to completely remove this plugin type, and all of the related usages and test coverage, from core in Drupal 9.

CommentFileSizeAuthor
#14 3088480-14.patch84.57 KBphenaproxima
#11 3088480-11.patch84.42 KBphenaproxima
#10 3088480-10.patch84.43 KBphenaproxima
#9 3088480-9.patch84.43 KBphenaproxima
#9 interdiff-3088480-2-9.txt924 bytesphenaproxima
#2 3088480-2.patch83.9 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3088480-2.patch83.9 KB

I cannot wait to see how many tests this breaks.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue summary: View changes
quietone’s picture

quietone commented
Status: Active » Needs review

Satisfying indeed!
I can't do a review now, too many irons in the fire already.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented

That is the prettiest patch I've seen since #3087546: Remove deprecated entity manager. When I opened it for a quick review, I had three or four things in my head that I thought might be easily missed, but you hit them all. I'm going to apply this patch and give the codebase a onceover before I RTBC, but I'm inclined to set a low bar to RTBC this (especially given passing tests with the deprecation suppressions removed). If we do find a reference in a comment or something else small later we can remove it in a follow up.

@PhenaProxima++

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

😁 Yup, this one also puts a smile on my face, big-time. I used PHPStorm to search for every instance of "cck" in core, and just deleted the ones that were related to this plugin type. Awww, yeah...

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs review » Needs work

Okay, one nit: 

core/modules/migrate_drupal/tests/src/Kernel/d7/FieldDiscoveryTest.php
line 6	Unused use statement
8	Unused use statement
10	Unused use statement
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

:smile:

44 files changed, 18 insertions, 1913 deletions.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 3088480-9.patch84.43 KB
new interdiff-3088480-2-9.txt924 bytes

Nit fixed.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3088480-10.patch84.43 KB

Okay, not sure why that didn't apply; it works on my machine. Maybe this one will work? 🤷‍♂️

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3088480-11.patch84.42 KB

TFW when you realize you were rolling the patches against the wrong branch. 🤦‍♂️

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community

No mentions of cck in any parts of Core. Except for D6 database dumps and d6 source plugins for i18n. I'd say this is good to go.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Issue tags: +Deprecation Removal
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3088480-14.patch84.57 KB

Reroll! Confirmed that there are no mentions of "cck", except in test fixtures and actual tests, after this patch.

quietone’s picture

quietone commented

I check for 'cck' as well and didn't find any except in tests, source plugins and migration/state. So, yes RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

The taxonomy stuff already got committed a few minutes ago in a taxonomy deprecation removals patch, but it was straightforward to just remove those hunks entirely from this patch.

Committed 98646a8 and pushed to 9.0.x. Thanks!

catch’s picture

catch
he/him
Primary language English
commented

  • catch committed a742158 on 9.0.x 
    Issue #3088480 by phenaproxima, mikelutz, quietone: Remove the "cckfield...
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

Yeah!!! What a wonderful way to celebrate Thanksgiving.

quietone’s picture

quietone commented

Lovely to see this in! Another good thing that happened while I am at Drupal South 2019.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.