Problem/Motivation

We didn't quite remove bin/composer from the root composer.lock file in #3082866: composer complains "Skipped installation of bin bin/composer for package composer/composer: file not found in package"

Proposed resolution

Update the composer.lock file appropriately.

Checkout branch
rm -rf vendor
composer install
composer update drupal/core

This should be applied to 9.0.x, 8.9.x and 8.8.x

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3088448-2.patch476 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3088448-2.patch476 bytes
greg.1.anderson’s picture

greg.1.anderson commented
Status: Needs review » Reviewed & tested by the community

Yeah, I have been seeing this a lot. +1

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

This should actually stay out this time.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

I'm not sure it actually matters after #3082866: composer complains "Skipped installation of bin bin/composer for package composer/composer: file not found in package", but it can't hurt to remove it.

greg.1.anderson’s picture

greg.1.anderson commented

People are seeing it in their diffs and wondering what's up; it should come out, so they can just rebase it away.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

yeah, now that #5 is in, it wont come back.

effulgentsia’s picture

effulgentsia commented

Adding reviewer credit.

  • effulgentsia committed 81be916 on 9.0.x 
    Issue #3088448 by alexpott, greg.1.anderson, Mixologic, Mile23: Remove...

  • effulgentsia committed 59b72d8 on 8.9.x 
    Issue #3088448 by alexpott, greg.1.anderson, Mixologic, Mile23: Remove...

  • effulgentsia committed 2b4033b on 8.8.x 
    Issue #3088448 by alexpott, greg.1.anderson, Mixologic, Mile23: Remove...
effulgentsia’s picture

effulgentsia commented
Version: 9.0.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks! Pushed to 9.0.x, 8.9.x, and 8.8.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.