Closed (fixed)
Project:
Translation Views
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Oct 2019 at 16:39 UTC
Updated:
15 Nov 2019 at 00:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
annya commentedComment #3
annya commentedRemove unused line of code.
Comment #4
annya commentedComment #5
matsbla commentedThe patch solves the problem! However I tried to make a test for it to add, and while doing that I discovered and solved some other smaller bugs. When fixing those I realize that if default target language is set to default site language it is negotiated different if the target language filter is limited to translation skills.
Here is an alternative approach that also seem like solves the problem. I'm still looking into it, and I also want to add an updated test.I've tried to fix it here
#3088956: Make sure target langcode is valid
but seems like this patch now need to be adjusted.
Comment #6
matsbla commentedComment #7
matsbla commentedreroll patch
Comment #8
matsbla commentedFix typo
+ $this->options['groups'],Should be $this->options['group']
Comment #9
matsbla commentedUndefined index: limit
Comment #10
matsbla commentedUpdate the view for testing in separate patch
Comment #12
matsbla commentedAdd test
Comment #14
matsbla commentedComment #15
matsbla commented