I was having a few minor/medium issues with this great module, and decided to address what I could:

  1. The Drupal Status Report Page now contains a warning section if the ipdata API key is not set.
  2. The configuration key name was used in several places throughout the code. I created a constant that can be reused. (IpKeySettingsForm::SETTINGS)
  3. Fixed admin page links and their placement in menus.
  4. Fixed problem with site-install and config-sync, where ip_lookup.settings.yml file was found but Drupal had problems linking it to the correct module, causing a failed installation.
  5. Fixed misspelling of 'configuration'.
CommentFileSizeAuthor
#4 status_report_page_code_improvements_spelling_corrections-3088285-4.patch4.7 KBarnaldop
#3 status_report_page_code_improvements_spelling_corrections-3088285-3.patch169 bytesarnaldop
ip_lookup.patch5.65 KBarnaldop

Comments

arnaldop created an issue. See original summary.

arnaldop’s picture

arnaldop
Location St Cloud, FL
commented

Marked issue 3087137 as a duplicate of this ticket and closed it.

This ticket includes improvements to the changes made in that ticket, plus other enhancements.

arnaldop’s picture

arnaldop
Location St Cloud, FL
commented
StatusFileSize
new status_report_page_code_improvements_spelling_corrections-3088285-3.patch169 bytes

Sorry, @Jiang_2015, my patch had a couple of issues do to differences between Git and Composer versions.

I missed that the spelling changes were already made. I also missed that my patch included your checks for missing fields, so the patch failed against the composer version when I also included the patch for 3087139.

Here is the patch without the changes to README.md and the last set of changes to Resource.php.

arnaldop’s picture

arnaldop
Location St Cloud, FL
commented
StatusFileSize
new status_report_page_code_improvements_spelling_corrections-3088285-4.patch4.7 KB

Argh, this should be the last one!
The previous one was a bad download somehow.

jiang_2015’s picture

jiang_2015 commented
Issue summary: View changes

Hi arnaldop,
Thank you so much for your help. I appreciated your patch. I am going to commit the code now and release a new version this weekend. Thank you again.

  • Jiang_2015 committed 55678a5 on 8.x-1.x authored by arnaldop 
    Issue #3088285 by arnaldop: Status Report page, code improvements,...
jiang_2015’s picture

jiang_2015 commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.