Due to cacheability issue glossify content is not getting updated if we are creating or updating the taxonomy term.

Steps to reproduce:

  • Create the vocabulary (e.g Glossary) to enable tooltip with taxonomy filter provided by glossify taxonomy module
  • Enable the tooltip with taxonomy filter provided by glossify taxonomy module for the required text format (e.g rich text, plain text etc) and for the above created vocabulary (e.g Glossary)
  • Create the taxonomy terms in the above created vocabulary (e.g Glossary)
  • Create the node of any content type which contain the configured text formats (e.g rich text, plain text etc)
  • Update the taxonomy term of the above created vocabulary (e.g Glossary), and navigate to above created node without clearing the cache
  • Notice that update made in the taxonomy term is not reflected on the node page without clearing the cache
  • Same is the issue when we are creating the new taxonomy term in the above created vocabulary (e.g Glossary) and if we already the content of that term in the node

Comments

Ankit Agrawal created an issue. See original summary.

ankit agrawal’s picture

Title: Glossify content not getting updated on updating the taxonomy term » Glossify content not getting updated on creating or updating the taxonomy term
Issue summary: View changes
ankit agrawal’s picture

StatusFileSize
new649 bytes

Created the patch with cache tag added for taxonomy_term_list as we do not have the vocabulary type specific cache tags

ankit agrawal’s picture

Assigned: ankit agrawal » Unassigned
Status: Active » Needs review
keesje’s picture

StatusFileSize
new2.24 KB

Hi, thanks for flagging. Can you try this new patch? I added cache-tags per term or node.

keesje’s picture

on second thought I see that this patch doesnt cover new added terms/nodes. OTH, I dont want to invalidate "list" cache tags, esp not with nodes. this could really trigger performance issues on big sites.
Maybe we have to wait for #2145751

tim-diels’s picture

Version: 8.x-1.0-beta1 » 8.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

The patch is good in my eyes and works for changes in current linked nodes/terms.

@keesje: I would not do that as in the issue, you can read comments that it would have a huge performance impact. For now I would be happy to have this patch comitted and open a new feature request where to discuss this?

So I'm setting this to RTBC. Let's get this in!

  • sanduhrs committed 48a5558 on 8.x-1.x authored by keesje
    Issue #3088199 by Ankit Agrawal, keesje: Glossify content not getting...
sanduhrs’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.