[D8] Markdown Exporter

There are lots of issue occurs while PAReview. Please resolve all of them. Thanks in advance.

A review should not simply report there are issues to fix, but also give a short description of what those issues are.

On the project used for this application, there are 14 commits done from ramit.mitra and 7 done from aniruddhab (for the 8.x-1.x branch).
Since the purpose of these applications is verifying what the user who applies understands about writing secure code that correctly uses the Drupal APIs and follows the Drupal coding standards, we cannot review code written from more users to understand what a single user understands of writing Drupal code.

If you want to become a vetted user who can opt into security coverage for the maintained projects, you need to apply using a project/branch where you committed most of the code, if not all.

Actually, for the 8.x-1.x branch there are commits from other users too, for example in markdown_exporter.drush.inc. We cannot review a project for which it is necessary to check every commit to understand exactly which user has done each change.

If the purpose of these applications were to check the code quality, we would not care of which user changed the code. The purpose of these applications is instead understanding what the user who applies understands on writing secure code that follows the Drupal coding standards, and correctly uses the Drupal APIs, which means we do care of which user wrote the code.

hi
Where drush commands? :-)
Please correct construct method in
https://git.drupalcode.org/project/markdown_exporter/blob/8.x-1.x/src/Fo...
must

/**
   * ContentTypeFieldMappingSettings constructor.
   *
   * @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
   * @param \Drupal\Core\Entity\EntityTypeManager $entity_type_manager
   * @param \Drupal\Core\Entity\EntityFieldManager $entity_field_manager
   */
  public function __construct(
    ConfigFactoryInterface $config_factory,
    EntityTypeManager $entity_type_manager, 
    EntityFieldManager $entity_field_manager
  ) {
    parent::__construct($config_factory);
    $this->entityTypeManager = $entity_type_manager;
    $this->entityFieldManager = $entity_field_manager;
  }

  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container) {
    return new static(
      $container->get('config.factory'),
      $container->get('entity_type.manager'),
      $container->get('entity_field.manager')
    );
  }

Use Json:decode instead json_decode

Hi aniruddhab,

Remove commented code from routing file
# markdown_exporter.github_auth_modal:
# path: '/admin/config/development/markdown_export/github-authentication/modal-open'
# defaults:
# _form: 'Drupal\markdown_exporter\Form\GitHubAuthModal'
# _title: 'GitHub Authentication'
# requirements:
# _permission: 'administer site configuration'

Service file :

services:
# markdown_exporter.entity_schema_subscriber:
# class: Drupal\markdown_exporter\EventSubscriber\MarkdownExporterEntitySchemaSubscriber
# arguments: ['@entity.manager']
# tags:
# - { name: 'event_subscriber' }

# core_file_system:
# class: Drupal\core\File\FileSystemInterface
# Drupal\core\File\FileSystemInterface: '@core_file_system'

Please remember to change status when the project has been fixed as per reviews.

There are some coding standards issues to be fixed in the README.md file.

FILE: ...ar/work/drupal-8/web/modules/contrib/markdown_exporter/README.md
----------------------------------------------------------------------
FOUND 1 ERROR AND 13 WARNINGS AFFECTING 14 LINES
----------------------------------------------------------------------
  11 | WARNING | [ ] Line exceeds 80 characters; contains 245
     |         |     characters
  13 | WARNING | [ ] Line exceeds 80 characters; contains 144
     |         |     characters
  35 | WARNING | [ ] Line exceeds 80 characters; contains 83
     |         |     characters
  41 | WARNING | [ ] Line exceeds 80 characters; contains 141
     |         |     characters
  57 | WARNING | [ ] Line exceeds 80 characters; contains 101
     |         |     characters
  59 | WARNING | [ ] Line exceeds 80 characters; contains 245
     |         |     characters
  61 | WARNING | [ ] Line exceeds 80 characters; contains 144
     |         |     characters
  88 | WARNING | [ ] Line exceeds 80 characters; contains 103
     |         |     characters
  89 | WARNING | [ ] Line exceeds 80 characters; contains 209
     |         |     characters
  90 | WARNING | [ ] Line exceeds 80 characters; contains 106
     |         |     characters
  91 | WARNING | [ ] Line exceeds 80 characters; contains 155
     |         |     characters
  97 | WARNING | [ ] Line exceeds 80 characters; contains 130
     |         |     characters
  99 | WARNING | [ ] Line exceeds 80 characters; contains 95
     |         |     characters
 106 | ERROR   | [x] Expected 1 newline at end of file; 8 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 512ms; Memory: 10Mb

1. permission file: "run markdown export" is unused. did you mean to use it for your routes in teh routing file?
2. markdown_exporter_entity_update(): if you are only targeting nodes then you should use hook_node_update() instead. Same for markdown_exporter_entity_insert().
3. class MarkdownExporterEntitySchemaSubscriber seems unused, can it be removed?
4. The function variable_get() does not exist anymore in Drupal 8, looks like your code does not work?
5. GitHubAuthSettings.php.bk: all backup files should be removed from the repository.

Although the module will probably not run on Drupal 8 because it might have some fatal errors (because variable_get() dores not exist) I don't see security issues.

Thanks for your contribution, Aniruddha!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

You have the git vetted user role, so everything should be ready for you to opt into security coverage in your project. Can you set the option when you edit your project at https://www.drupal.org/node/3055800/edit ?

Nice, then I think we can close this again.