Postponed
Project:
Drupal core
Version:
main
Component:
entity system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
13 Oct 2019 at 04:21 UTC
Updated:
10 Jun 2022 at 03:13 UTC
Jump to comment: Most recent
Comments
Comment #7
quietone commentedI do see tests for createWithSampeValues, \Drupal\KernelTests\Core\Entity\CreateSampleEntityTest::testSampleValueContentEntity. It validates entities, including node, and does test the randomly generate title. That test predates this issue so I am not sure what still needs to be tested. It was added in #2905527: Introduce a sample value entity method to ease plugin filtering via context.
I'll asked in #bugsmash, maybe I am missing something.
Comment #8
quietone commentedI asked chx about this in #bugsmash. As I understand it what is needed is a test of createWithSampleValues using all the fields on an entity.
Writing tests is normally a task, changing category.
Comment #9
quietone commentedchx posted some more in #bugsmash. He recommends that this should be postponed on #2915034: \Drupal\Core\Entity\ContentEntityStorageBase::createWithSampleValues() does not handle language or bundles correctly, "because the test changes in there are very, very good, namely saving and loading the sample back".
I've added the postponed issue to the Remaining tasks and setting this postponed.
Comment #10
ghost of drupal past