From @cboyden after testing #3084560: Ensure that when the Media Library disables media items so that they cannot be selected, that they are also disabled for screenreader access

Lucy and I reviewed the patch. The disabled elements are still announced as "clickable," but, clicking on the "clickable" elements no longer does anything. The NVDA user is no longer able to select more items that are allowed by the field.

For each library item, there are two clickable elements that are available when using NVDA's arrow navigation. Either one works to select the item. It would make for better screenreader usability if there were only one actionable element per media item.

The original ticket can be referenced for more context, and this interaction can be viewed on the video recording of the September 29, 2019 walkthrough of Media Library starting at around minute 6:30 and continuing to minute 9:45.

Additional note: addressing this will also improve the experience for keyboard-only users (in addition to screenreader users), as it will reduce the number of tabs required to interact with the interface.

CommentFileSizeAuthor
#4 author-field.png491.82 KBbnjmnm

Comments

rainbreaw created an issue. See original summary.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

This is due to the author link inside each media item. This link has some additional problems as well.

  • When this link is clicked in a not-dialog (a list of existing media in a field, for example), clicking will result in an alert with Unsaved changes to the form will be lost. Are you sure you want to leave?, then the user is taken to the user's profile.
  • When this link is clicked inside a dialog, the same alert is triggered, but even if "OK" is clicked, the user is not taken to a new location

Based on this, it seems like changing the author link to a span would be the best way to address this. I don't think there is a pressing need to be able to access the user profile of the media's creator. If there is, then the link needs to be fixed in the dialog as well.

Thoughts/concerns on changing this to a span?

zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
commented

Do you mean change it to a span permanently or just when an item is disabled?
Either way, removing anything the screenreader thinks is clickable should be a good approach to preventing an item from being selected.

In that video I didn't see anything about author info, is that a hidden field? I didn't notice it in source on my local, but I may have a different config.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
StatusFileSize
new author-field.png491.82 KB

@zrpnr I'm so accustomed to using the media types from the media_library_test module I overlooked the fact that these aren't added by default. These are examples of the clickable author link (that doesn't actually work in dialogs) within the clickable media item
.

Realizing that, the problem reported does occur when there's a link inside a media item, so that will still need to be addressed. It will probably need to be done on the JS level rather than changing the element type for author, since other links could be added as part of the display.

In the meantime, I'll have to look further into how they managed to run into that issue without a link as part of the media item display.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

acbramley’s picture

acbramley commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: +Bug Smash Initiative

Triaged as part of BSI.

This was originally reported in 8.9, is this still an issue in Drupal 11?

acbramley’s picture

acbramley commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Closing this as outdated for now. The other referenced issue from the IS isn't in either I'm not too sure where this would stand regardless.

If this is still an issue, please feel free to reopen it.