Email isn't actually required to synchronize user properties so it would be useful to ignore email synchronization if user_mail_attribute is empty.

CommentFileSizeAuthor
#2 ignore_email_sync-3087233-2.patch692 bytespiggito

Comments

piggito created an issue. See original summary.

piggito’s picture

piggito commented
StatusFileSize
new ignore_email_sync-3087233-2.patch692 bytes

Attached patch implements the functionality described in issue summary.

piggito’s picture

piggito commented
Assigned: piggito » Unassigned
Status: Active » Needs review
davidferlay’s picture

davidferlay commented
Status: Needs review » Reviewed & tested by the community

Tested OK !

andypost’s picture

andypost
he/him
Primary language Russian
commented
Parent issue: » #3098165: Path to beta release
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Needs tests
nguerrier’s picture

nguerrier commented
Related issues: +#3103165: Remove default value for user name and email attributes

Kinda related #3103165: Remove default value for user name and email attributes

  • roderik committed 6d49152 on 8.x-3.x authored by piggito 
    Issue #3087233 by piggito, davidferlay: Ignore e-mail synchronization if...
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Reviewed & tested by the community » Fixed

Thanks. I can't think of a reason why this should be done any differently / why e.g. this change should be especially concerned about creating a new user without e-mail address.

As said in #2882568: Plan for SAML Authentication 4.x: I agree it needs tests, but the whole module needs tests... so no reason to not commit this first.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.