Closed (fixed)
Project:
User IP Lookup
Version:
8.x-1.3
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Oct 2019 at 15:27 UTC
Updated:
28 Oct 2019 at 23:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
arnaldopComment #4
jiang_2015 commentedThank you so much for your commit. I appreciate your help. Just committed the code.
Comment #5
jiang_2015 commentedI think I need to delete the "else" statement. otherwise, it won't send Http request when the user has the correct config.
I set the default API key as "test". default key will let the user use ipdata for a few lookups until they have a right API key.
Comment #7
jiang_2015 commentedI updated the patch. I handled the error when send the Http request at "fetchProjectData"
We don't need to try catch again. The error you have onscreen is because I didn't check if $details->ip is empty. I updated the patch.
Thank you again for your help.
Comment #9
jiang_2015 commented