Closed (fixed)
Project:
SAML Authentication
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Oct 2019 at 07:15 UTC
Updated:
3 May 2021 at 14:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
antonnaviAttached patch solves this issue.
Mb some UI to manage
NameIDPolicyneeded here?(at list checkbox to be able set it
TRUE/FALSE)Comment #3
antonnaviComment #4
antonnaviComment #5
davidferlay commentedTested OK !
Comment #6
nironan commentedI had the same problem with 7.x and decided to make the NameIdPolicy configurable (active by default). Patch attached
Comment #7
roderikPatches for new functionality are appreceated - in any state of being finished. And I also appreciate that this patch made me think more about what the NameID related options really do, because I had not fully thought that through yet.
But you can help by keeping the issue status realistic. @davidferlay just a quick test is not enough to set an issue to RTBC status; it is for things that were actually reviewed and considered "probably in a good state to commit". That's much not the case with the issue you tested because it changed default functionality for other users, without any way to influence that functionality (UI).
I've added that UI into the D8 version myself, rather than setting this issue back to Needs Work, because it was time to think through some other issues / options in the UI, including the relation between this issue and #3086827: Add UI to set NameId not required. which was not clear to me.
As a result, I've split the 'security' options into two sections in a previous commit, changed some descriptions and default values, and opened #3131028: Advanced/security options UX / default values to store some thoughts.
I am/was also curious if people could not also have solved this by setting a different 'Name ID Format'. However, I don't think that is a reason to not include this option.
Comment #9
roderikI guess this goes back to Needs Review for the 7.x version...
Comment #11
roderikThank you; committed now. (I suspect that this checkbox is a bit off in the 'Security' section, but that isn't a real issue. And the D8 version, while evolved a little bit, isn't done fixing up its NameID handling yet either.)