Now that the system monitor logging system has been wireframed, it should be possible to create tests for the functionality present in that framework.
This ticket is considered complete when the logging system has tests covering its critical systems. It is not required that ALL lines be covered and whoever works on this should use their best judgement as to how far to take the tests so they are still meaningful.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | system_monitor--tests-for-logs--3086306--3.patch | 6.18 KB | merauluka |
Comments
Comment #2
merauluka commentedAssigning to myself.
Comment #3
merauluka commentedAdding patch with preliminary tests. These can provide a basis for future test expansion.
Comment #4
robpowellThis actually returns a boolean.
This method returns a $query->execute()->fetchAllAssoc('log_id'), which could also be null.
Same as above
Actually should there be two hasActiveIncident()?
Comment #5
robpowellComment #6
merauluka commented@robpowell I think your above comment was actually for #3086358: Implement Status Check logic for SystemMonitorTaskManager
Comment #7
merauluka commentedPutting this back to Needs Review.
Comment #8
robpowelldisregard
Comment #9
robpowellComment #10
robpowellDisregard last comment this looks good.
Comment #11
robpowellComment #13
merauluka commentedMerged! Thanks @robpowell for the review!