Closed (fixed)
Project:
System Monitor
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Oct 2019 at 15:02 UTC
Updated:
28 Oct 2019 at 19:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
merauluka commentedAssigning to myself.
Comment #3
merauluka commentedAdding patch with preliminary tests. These can provide a basis for future test expansion.
Comment #4
robpowellThis actually returns a boolean.
This method returns a $query->execute()->fetchAllAssoc('log_id'), which could also be null.
Same as above
Actually should there be two hasActiveIncident()?
Comment #5
robpowellComment #6
merauluka commented@robpowell I think your above comment was actually for #3086358: Implement Status Check logic for SystemMonitorTaskManager
Comment #7
merauluka commentedPutting this back to Needs Review.
Comment #8
robpowelldisregard
Comment #9
robpowellComment #10
robpowellDisregard last comment this looks good.
Comment #11
robpowellComment #13
merauluka commentedMerged! Thanks @robpowell for the review!