Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
4 Oct 2019 at 05:17 UTC
Updated:
25 Oct 2019 at 05:56 UTC
Jump to comment: Most recent
Comments
Comment #2
dmezquiaComment #3
dmezquiaComment #4
phthlaap commentedPlease update this issue, add the project information follow the template on this post:
https://www.drupal.org/node/1011698
Comment #5
dmezquiaComment #6
er.garg.karanReview for the release 8.x-1.x
Make sure you do not exceed max allowed characters per line.
Remove commented code from the function settingsForm. It is highly recommended to have commented code.
Try not to use the most generic name style.css. Try using a name that matches your module name or the feature for which the file is being used for.
Comment #7
dmezquiaThank @er.garg.karan, the adjustments you indicate to me are already ready for 8.x-1.x.
Comment #8
anokr commentedHi,
Review for 8.x-1.x
1. file : PrettyOptionsWidget.php, line 55 comment is not as per Drupal Standard.
and if it is unnecessary code then it can be removed.
Thanks
Comment #9
dmezquiaHi @AnokR , thank for the feedback, that code is already removed.
https://git.drupalcode.org/project/pcr/blob/8.x-1.x/src/Plugin/Field/Fie...
Comment #10
avpadernoI added the Git instructions for non-maintainer users.
Comment #11
dmezquiaHi @kiamlaluno, has that something to do with passing the module to security coverage?
Comment #12
vuilThank you for the contribution!
I have not found any security related issue into the project's code.
Nice module and very good UX / UI implementation!
I set the issue's status to Reviewed and tested by community.
Comment #13
dmezquiaThank @ilchovuchkov .
Comment #14
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #15
dmezquiaThank @kiamlaluno
Comment #16
dmezquiaHi @kiamlaluno, some update about this?
Comment #17
vuil@diosbelmezquia Please read carefully all the mentioned documentation and content pages in #14.
The issue is Fixed, so feel free to edit your project's page and set it up to the security coverage.
Comment #18
dmezquiaThank @ilchovuchkov
Comment #20
vuil