php drupal-check.phar modules/contrib/geshifilter/
 26/26 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------------- 
  Line   geshifield/src/Plugin/Field/FieldFormatter/GeshiFieldDefaultFormatter.php  
 ------ --------------------------------------------------------------------------- 
  32     Call to deprecated function drupal_render().                               
 ------ --------------------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   geshifilter.install                                
 ------ --------------------------------------------------- 
  19     Call to deprecated function drupal_set_message().  
  24     Call to deprecated method l() of class Drupal.     
  25     Call to deprecated method l() of class Drupal.     
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/GeshiFilterLanguagesForm.php              
 ------ --------------------------------------------------- 
  58     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ------------------------------------------------------------------- 
  Line   src/Form/GeshiFilterSettingsForm.php                               
 ------ ------------------------------------------------------------------- 
  56     Call to deprecated method l() of class Drupal\Core\Form\FormBase.  
  57     Call to deprecated method l() of class Drupal\Core\Form\FormBase.  
  92     Call to deprecated method l() of class Drupal.                     
  136    Call to deprecated method l() of class Drupal.                     
  153    Call to deprecated method l() of class Drupal.                     
  162    Call to deprecated method l() of class Drupal.                     
  196    Call to deprecated method l() of class Drupal.                     
  199    Call to deprecated method l() of class Drupal.                     
  200    Call to deprecated method l() of class Drupal.                     
  239    Call to deprecated method l() of class Drupal.                     
  307    Call to deprecated function drupal_set_message().                  
 ------ ------------------------------------------------------------------- 

 ------ ------------------------------------------------ 
  Line   src/GeshiFilter.php                             
 ------ ------------------------------------------------ 
  245    Call to deprecated method l() of class Drupal.  
  246    Call to deprecated method l() of class Drupal.  
 ------ ------------------------------------------------ 

 ------ ------------------------------------------------------- 
  Line   src/GeshiFilterCss.php                                 
 ------ ------------------------------------------------------- 
  40     Call to deprecated function file_prepare_directory().  
  82     Call to deprecated function drupal_set_message().      
  107    Call to deprecated function drupal_set_message().      
  110    Call to deprecated function drupal_set_message().      
 ------ ------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/GeshiFilterProcess.php                                                            
 ------ -------------------------------------------------------------------------------------- 
  69     Call to deprecated function drupal_set_message().                                     
  97     Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  97     Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  116    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  116    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
 ------ -------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/Plugin/Filter/GeshiFilterFilter.php                                               
 ------ -------------------------------------------------------------------------------------- 
  125    Call to deprecated function drupal_set_message().                                     
  196    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  196    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  197    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  197    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  199    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  199    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  203    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  203    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  204    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  204    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  206    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  206    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  210    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  210    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  211    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  211    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  213    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  213    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  217    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  217    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  218    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  218    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  220    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  220    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  223    Call to deprecated function drupal_set_message().                                     
  224    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  224    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  225    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  225    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  374    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  374    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  377    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  377    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  934    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  934    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  949    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  949    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
  999    Call to deprecated method checkPlain() of class Drupal\Component\Utility\SafeMarkup.  
  999    Call to method checkPlain() of deprecated class Drupal\Component\Utility\SafeMarkup.  
 ------ -------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 67 errors 

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

Status: Active » Needs review
StatusFileSize
new21.17 KB

Here is the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: deprecated-3085386-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Deeksha B’s picture

Status: Needs work » Needs review
StatusFileSize
new20.17 KB

Please review the patch.

yukare’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev

Change for new branch for Drupal 8.8 and 9.

yukare’s picture

StatusFileSize
new29.9 KB

Patch for Drupal 8.8 and i hope for 9. It have some other small fixes so it pass on tests.

yukare’s picture

StatusFileSize
new32.3 KB

With this patch the tests pass on Drupal 8 but we still have some issues in Drupal 9, but i think its better open small issues for everything missing here or we will have a big patch with many unrelated issues.

Status: Needs review » Needs work

The last submitted patch, 7: 3085386-7.patch, failed testing. View results

  • yukare committed 7b88987 on 8.x-2.x
    Issue #3085386 by yukare, Sergiu Stici, Deeksha B: Deprecated Code...
yukare’s picture

Status: Needs work » Fixed

This last patch fix this issue(deprecated code in Drupal 8), we still need work more for Drupal 9, but it is out of this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.