Closed (fixed)
Project:
Drupal core
Version:
9.1.x-dev
Component:
Claro theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Oct 2019 at 14:01 UTC
Updated:
28 Oct 2020 at 01:29 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #2
huzookaComment #3
kbasarab commentedCurrent status report screenshots:
## Available Updates Page
## Status Report
## Status Report Table Design
New Design System Files: https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Drupal-Design-system
Comment #4
kbasarab commentedComment #5
huzookaRe #3, #4:
This issue is about the maintenance page.
Comment #6
igonzalo commentedI think this issue is not clear enough, in the title it is specified that maintenance page should be redesign but in Problem/Motivation the page that should be redesign is Available updates.
Please clarify it. Thanks
Comment #7
lauriiiHere's a screenshot of the maintenance page in Seven.
Comment #8
Jongruk Timmanee commentedI'm planning to work on the designs
Comment #9
Jongruk Timmanee commentedThis is where I got so far.
Please feel free to make comments 😇
https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Drupal-Design-system...
Comment #10
Jongruk Timmanee commentedComment #11
ckrinaComment #13
lauriiiThis is blocked on #3085219: Installer is not very usable in Claro to ensure that the designs are consistent.
Comment #14
lauriiiWe don't want to postpone this on the installer issue anymore, because it was removed from the stable blockers. However, we still need a design before we can start implementing this.
Comment #15
saschaeggiComment #16
saschaeggiComment #17
saschaeggiDesign is updated and it can be worked on now.
Quick specs:

=> get the latest specs from here: https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Drupal-Design-system...
Comment #18
lauriiiStarted implementing this
Comment #19
dyannenovaThis looks close. The text inside of the layout container needs a max width of 512px, and the border radius should be 8px.
Comment #20
komalk commentedWorked on #19.
Comment #21
dyannenova#20 fixed the border radius, but instead of limiting the text width it limits the entire layout container. In the spec, the layout container has a max width of 940px and the text area inside has a max width of 512px.
Patch

Goal

Comment #22
komalk commented@DyanneNova Thanks for the review.
Limiting the max-width of the layout container to 940px and the text area inside it max-width of 512px.
Comment #23
dyannenovaThis looks good to go now. Thanks @komalkolekar!
Comment #24
bnjmnmReroll
Comment #25
lauriiiAnother reroll 🎢
Comment #27
effulgentsia commentedLooks good! I pushed this to 9.1.x, but I had to also apply this interdiff, which just re-orders properties in the compiled CSS to match how the compiler currently orders them.
Comment #28
effulgentsia commentedRemoving issue credit from myself. #27 is trivial, and I didn't credit myself in the commit message either.