Problem/Motivation

For this issue:
* Server-side-Ajax = Client requests an ajax endpoint; server determines the changes, the ajax-commands response is processed by ajax.js.
* Client-side-Ajax = Client requests some html page/snippet and inserts it at a location determined by the client (and unknown to the server)

This is important for embedding media if they carry some JS behaviors (like blazy).

Entity-embed and media library use clientside ajax and currently ignore all JS (and CSS) attachments, making embedded entities/media break. See #2882866: Provide a preview display setting for use in WYSIWYG editors, improves authoring ergonomics, #3084312: Make (embedded entities') JS work inside CKEditor.

As the related issue shows, loading JS correctly is nontrivial so we should not reinvent the wheel.

Proposed resolution

* Leverage the existing JS/CSS attachment logic in a helper for clientside ajax
* If necessary, port the improvements from #1988968: Drupal.ajax does not guarantee that "add new JS file to page" commands have finished before calling said JS

Remaining tasks

TBD

User interface changes

None.

API changes

Add said helper.

Data model changes

None.

Release notes snippet

None.

Comments

geek.merlin aka axel.rutz created an issue. See original summary.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Issue summary: View changes
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Issue summary: View changes
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

The discussion in the other tickets indicates we might not need this for media / entity_embed. Otoh i remember i needed this for leaflet_map ajax (i worked around this using serverside ajax, but having this would make significant better DX here). So still an issue.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Leverage (server-side-ajax) JS logic for clientside ajax » Leverage (server-side-ajax) JS logic for client-side AJAX

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

nod_’s picture

nod_
Primary language French
Location Lille
commented

Core issue mentioned in the issue summary is now fixed for 9.5+ branches :) no need for a workaround

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.