Instead of having option "Only allow to translate if source language is a registered source skill", maybe it would make more sense to have "Use strict translation skill pairing", that not only control for source language, but the language combination (that both source/target language match). I think it would make more sense, than to only control for the source language.

CommentFileSizeAuthor
#11 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-10.patch26.61 KBmatsbla
#10 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-9.patch26.63 KBmatsbla
#9 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-8.patch26.2 KBmatsbla
#8 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-7.patch22.22 KBmatsbla
#7 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-6.patch21.58 KBmatsbla
#6 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-5.patch23.6 KBmatsbla
#4 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-4.patch15.44 KBannya
#3 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-3.patch15.13 KBannya
#2 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-2.patch14.92 KBannya

Comments

annya created an issue. See original summary.

annya’s picture

annya commented
StatusFileSize
new 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-2.patch14.92 KB
annya’s picture

annya commented
StatusFileSize
new 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-3.patch15.13 KB
annya’s picture

annya commented
StatusFileSize
new 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-4.patch15.44 KB
annya’s picture

annya commented
Status: Active » Needs review
matsbla’s picture

matsbla commented
StatusFileSize
new 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-5.patch23.6 KB

Thanks for the patch! It looks good.
I've fixed some coding standards issues and variable names.
Also tried to fix the permission when "Preset source language to translation skills" is disabled.
Also tried to add a new test for it.
Can you look over and give me feedback?

matsbla’s picture

matsbla commented
StatusFileSize
new 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-6.patch21.58 KB

Update patch after fixing #3088160: Source language is not preset when Content Translators permissions is disabled

matsbla’s picture

matsbla commented
StatusFileSize
new 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-7.patch22.22 KB

Also fix readme

matsbla’s picture

matsbla commented
StatusFileSize
new 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-8.patch26.2 KB

Also fix getTranslationSourceLangcode when strict translation pairing is enabled.

matsbla’s picture

matsbla commented
StatusFileSize
new 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-9.patch26.63 KB

Fix source language group filtering in form when strict translation skill pairing is disabled.

matsbla’s picture

matsbla commented
StatusFileSize
new 3083953-replace-allow-translate-for-source-option-to-strict-translation-skill-pairing-10.patch26.61 KB

Coding standards

  • matsbla committed 1ecf8c6 on 8.x-1.x 
    Issue #3083953 by matsbla, annya: Replace allow translate for source...
matsbla’s picture

matsbla commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.