Problem/Motivation

We noticed this error:

Error: Call to a member function save() on null in /app/web/modules/contrib/dropzonejs/modules/eb_widget/src/Plugin/EntityBrowser/Widget/InlineEntityFormMediaWidget.php on line 178 #0 [internal function]: Drupal\dropzonejs_eb_widget\Plugin\EntityBrowser\Widget\InlineEntityFormMediaWidget->submitEdit(Array, Object(Drupal\Core\Form\FormState))

This happens because \Drupal\dropzonejs_eb_widget\Plugin\EntityBrowser\Widget\DropzoneJsEbWidget::getFiles adds whatever it gets from \Drupal\dropzonejs\DropzoneJsUploadSave::createFile to $files.

A case when this might happen if size validation failed.

Proposed resolution

Check if the entity was created.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3083640-check-created-entity-2.patch605 bytesprimsi

Comments

Primsi created an issue. See original summary.

primsi’s picture

primsi commented
Status: Active » Needs review
StatusFileSize
new 3083640-check-created-entity-2.patch605 bytes

Small patch that should address this.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Not sure if we can add a test for this, would probably have to set the max file size very low?

primsi’s picture

primsi commented
Related issues: +#3086881: Add test coverage to eb_widget

  • Primsi committed 0a9c56f on 8.x-2.x 
    Issue #3083640 by Primsi, Berdir: Check before adding the result of...

  • Primsi committed 72bf009 on 8.x-1.x 
    Issue #3083640 by Primsi, Berdir: Check before adding the result of...
primsi’s picture

primsi commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.