The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.The tests are currently failing on the 8.x-1.x branch, resolve these so that everything can be happy with the world.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | scanner-n3083587-8.interdiff.txt | 817 bytes | damienmckenna |
| #8 | scanner-n3083587-8.patch | 31.53 KB | damienmckenna |
| #7 | scanner-n3083587-6.patch | 46.62 KB | damienmckenna |
| #3 | admin-settings-tests-coding-standards-3083587-3.diff | 31.75 KB | codebymikey |
Comments
Comment #2
kswamy commentedHi,
Any update on these tests. We need this module for D8
Comment #3
codebymikey commentedHi @DamienMcKenna,
I've updated the admin settings code so that it'll pass the functional tests.
The main reason the test was failing was because the
#default_valueof theenabled_content_typesform element wasNULLrather than an array due to the lack of a default config installation value.I've cleaned up most of the admin settings related code and made the admin settings tests more extensive.
Can you review and let me know what you think about the code changes.
Also, is there any reason we don't support the
string_longfield type?Comment #4
codebymikey commentedThe new test introduces a test only dependency on
paragraphsin order to test its integration with it.Would it be possible to commit the
test_dependenciesproperty to the upstream code so that the testbot can pick it up?Comment #5
damienmckennaI tagged 1.0-rc1 but forgot this issue. Sorry.
Comment #7
damienmckennaI committed the test_dependency change, this is a reroll of the patch (and fixes the file permissions).
Comment #8
damienmckennaThis fixes a problem with the test trait.
Comment #10
damienmckennaCommitted. Thanks!