Comments

vishalkhialani created an issue. See original summary.

rensingh99’s picture

I will work on this.

rensingh99’s picture

I have created a patch. Please review it.

akshay.kelotra’s picture

Status: Active » Reviewed & tested by the community

I have reviewed this patch and tested it. It is working fine.

neeravbm’s picture

Status: Reviewed & tested by the community » Fixed

I have merged this patch to dev branch.

  • rensingh99 authored a73db9a on 8.x-1.x
    Issue #3083047 by rensingh99, vishalkhialani, akshay.kelotra, neeravbm:...
damienmckenna’s picture

Was this an update to rete-vue-render-plugin that included the fix, or did you change the file directly? It's hard to tell when the change is in a minimized file. If it's the former then shouldn't the version number have changed? If the latter, how are you tracking changes made to that file? That way, if there's a new version of rete-vue-render-plugin how will you know what changes have been applied?

akshay.kelotra’s picture

It is a change in rete-vue-render-plugin, but rather than using the original Plugin we customized it and created a new build specific to this project. So that's why we didn't update the version and that's why it is in a minified version.

damienmckenna’s picture

You should to include the modified version with this repository so that other folks can submit patches against it too.

akshay.kelotra’s picture

Status: Fixed » Closed (fixed)