Closed (fixed)
Project:
If Then Else
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
23 Sep 2019 at 11:51 UTC
Updated:
15 Oct 2019 at 06:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
rensingh99 commentedI will work on this.
Comment #3
rensingh99 commentedI have created a patch. Please review it.
Comment #4
akshay.kelotra commentedI have reviewed this patch and tested it. It is working fine.
Comment #5
neeravbm commentedI have merged this patch to dev branch.
Comment #7
damienmckennaWas this an update to rete-vue-render-plugin that included the fix, or did you change the file directly? It's hard to tell when the change is in a minimized file. If it's the former then shouldn't the version number have changed? If the latter, how are you tracking changes made to that file? That way, if there's a new version of rete-vue-render-plugin how will you know what changes have been applied?
Comment #8
akshay.kelotra commentedIt is a change in rete-vue-render-plugin, but rather than using the original Plugin we customized it and created a new build specific to this project. So that's why we didn't update the version and that's why it is in a minified version.
Comment #9
damienmckennaYou should to include the modified version with this repository so that other folks can submit patches against it too.
Comment #10
damienmckennaI opened a separate issue about this: #3085788: Clear each JS library through the Licensing Working Group (drupal_lwg), or remove JS libraries
Comment #11
akshay.kelotra commented