Dependencies must be prefixed with the project name

CommentFileSizeAuthor
ics_field-56-156681120.patch358 bytespifagor

Issue fork ics_field-3082890

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pifagor created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Needs work

According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Also, the name of the module should be capitalized.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented

This is still active. However, the uploaded patch only adds a prefix for the datetime module. Not for token.

jeroent opened merge request !22

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Reviewed & tested by the community

stefanos.petrakis made their first commit to this issue’s fork.

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented

Looks good, thank you people!

Re. this comment:
I didn't find in that docu page that `name:` should follow Drupal's capitalization; it said so much for the `package:` property, but not for `name:`. I decided to rename the module still to sth more human readable.

Going to commit this now

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented
Version: 8.x-1.x-dev » 3.x-dev
Status: Reviewed & tested by the community » Fixed

Assigning credit and closing issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.