Needs review
Project:
Address Field
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Sep 2019 at 18:15 UTC
Updated:
14 Oct 2020 at 14:57 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
lwalley commentedComment #3
lwalley commentedComment #4
lwalley commentedOn second review using language code from entity in the absence of the multi-value patch in #2679579: Token values unavailable for multi-value address fields is probably effectively the same as just setting language code to LANGUAGE_NONE so probably isn't the right choice here. It doesn't solve the root issue which is that $options is "en" but address field array index is "und". Further investigation is needed.
Comment #5
lwalley commentedNew patch, also doesn't solve the root cause but at least only changes the language if it isn't supported by address field.
Comment #6
ciss commentedI'd like to offer an alternative solution that explicitely checks if the field in question is translatable. I've left patch #5 visible so that both solutions can be compared.
Comment #7
ciss commentedNote that these patches still don't handle entity translation. In another project that uses entity translation we ended up patching out addressfield.tokens.inc completely (possible because we already use the entity module and don't rely on underscore field tokens).
Comment #8
tintoPatch #5 solves the issue for me