Closed (fixed)
Project:
Drupal core
Version:
8.8.x-dev
Component:
field system
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Sep 2019 at 10:14 UTC
Updated:
8 Oct 2019 at 03:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottComment #3
alexpottSo the reason that this is not casted to a Boolean is that we have special logic around null values \Drupal\Core\Config\StorableConfigBase::castValue() in specifically:
So we leave nulls alone. This is a much much wider issue if we want to fix that. I think the current small fix is okay but I'll check for follow-ups about this wider issue of config and nulls. Config schema does have the concept of
nullablebut funnily enough this is only really supported by sequences and mapping types - even if there places in core where people have added it to scalars.Comment #4
alexpottComment #6
mondrakeDo we need @todos to revert this to assertTrue and assertFalse in #2742585: Deprecate dangerous assertTrue/False() compatibility overrides in PHPUnit Kernel, Functional and FunctionalJavascript tests? Other than that, RTBC I'd say
Comment #7
mondrake#6 not necessary, will be done in a bulky way later.
Comment #8
mondrakeCritical as it is holding the Critical parent
Comment #9
krzysztof domański1. The patch contained code from another issue #3082287: \Drupal\user\Plugin\views\access\Role::access() does not conform to the base class documentation. I deleted it.
2. Follow-up for #6: #3082415: Replace assert(Not)Same/Identical() on booleans with assert(Not)True/False() in PHPUnit tests.
3. Needs follow-up for #3.
Comment #11
alexpottwhoops... @Krzysztof Domański thanks for tidying that up!
Comment #14
catchCommitted 9af697c and pushed to 8.8.x. Thanks!
Comment #15
jibran