Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
18 Sep 2019 at 13:24 UTC
Updated:
18 Oct 2019 at 08:19 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoThank you for applying! I added the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.
If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.
Comment #3
avpadernoComment #4
vuilThank you for the contribution!
(1.) Please update your README.md file and add the required Headings in uppercase (https://www.drupal.org/node/2181737).
(2.) Please apply Drupal Coding standards, especially in:
(3.) Please fix the following
pareview.shissue:DrupalPractice has found some issues with your code, but could be false positives.
Comment #5
avpadernoComment #6
eescribanoc commentedFixed feedback from comment #4
Comment #7
avpadernoFixed is used when the application has been approved. The code still needs to be reviewed.
Comment #8
avpadernoComment #9
eescribanoc commented@kiamlaluno what are the next steps, is there anything I have to do?
Comment #10
avpadernoI was just waiting 14 days passed since the project creation, as a project cannot opt into security coverage in the first 14 days since its creation.
Comment #11
avpadernoThank you for your contribution! I am going to update the project to opt it into security coverage.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #13
vuil