The module Video Embed Tencent Provider adds a new provider for Tencent videos for "video embed field" module.
There was an issue in their queue to add the providers Tencent and Youku but the maintainers suggested that those providers should be their own modules.

Project link

https://www.drupal.org/project/video_embed_tencent

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/video_embed_tencent.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-video_embed_te...

Comments

e.escribano created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes

Thank you for applying! I added the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

avpaderno’s picture

vuil’s picture

Thank you for the contribution!

(1.) Please update your README.md file and add the required Headings in uppercase (https://www.drupal.org/node/2181737).

(2.) Please apply Drupal Coding standards, especially in:

  • src/Plugin/video_embed_field/Provider/Tencent.php

(3.) Please fix the following pareview.sh issue:
DrupalPractice has found some issues with your code, but could be false positives.

FILE: .../vendor/drupal/pareviewsh/pareview_temp/video_embed_tencent.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 7 | WARNING | All dependencies must be prefixed with the project name,
   |         | for example "drupal:"
--------------------------------------------------------------------------
avpaderno’s picture

Status: Needs review » Needs work
eescribanoc’s picture

Status: Needs work » Fixed

Fixed feedback from comment #4

avpaderno’s picture

Status: Fixed » Needs review

Fixed is used when the application has been approved. The code still needs to be reviewed.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Reviewed & tested by the community
eescribanoc’s picture

@kiamlaluno what are the next steps, is there anything I have to do?

avpaderno’s picture

I was just waiting 14 days passed since the project creation, as a project cannot opt into security coverage in the first 14 days since its creation.

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update the project to opt it into security coverage.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vuil’s picture