Quantity price calculation not computed/displayed until update cart pressed

So I've been working on this and I was able to get a little farther by including this code:

      $settings = $order_item->setQuantityPrices($form_object, $this, $form_state);


/* CUSTOM */
      if ($price = $order_item->getQuantityPrice($form_object, $order_item->getPurchasedEntity(), $order_item->getQuantity())) {

        if (!$price->equals($order_item->getUnitPrice())) {
          $order_storage = $this->entityTypeManager->getStorage('commerce_order');
          $cart = $order_storage->load($this->view->argument['order_id']->getValue());
          $order_item->setUnitPrice($price, TRUE);
          $this->cartManager->updateOrderItem($cart, $order_item, FALSE);
          $this->viewsFormSubmit($form, $form_state);
        }
      }

      //$order_item->getQuantityPrice($form_object, $order_item->get('purchased_entity')->first()->getValue(), $order_item->getQuantity());
      
/* END CUSTOM */


      if (is_string($settings['prefix']) && !empty($settings['prefix'])) {

in src/views/field/xquantityeditquantity.php inside the viewsform() function, using code I basically jacked from the viewsformsubmit()

Doing this, I can now just refresh the cart page after adding 400 of an item from the product page and clicking cart, and the correct price is displayed without having to change the quantity and hit "update cart", but if you go to checkout the item total is correct but the cart total is still the wrong number. Obviously this is because I'm not actually recomputing the cart price in the above hacky garbage I wrote.

However, it seems like this makes it quite clear that the module isn't running the quantity discount price check stuff, either because I misconfigured something somewhere or it's a use case that wasn't considered when it was created. I will continue trying to figure out what is going on here, but I would appreciate any help I can get.

@drugan

I followed your instructions and verified everything, everything seems to be configured correctly. It kind of seems related to the ajax support, but I don't use AJAX for the cart, when you hit "add to cart" on a product the page itself refreshes on the product page, and then you can click on the cart icon to go to your cart and see the item(s) you added.

Here are some screenshots of my configuration and what is happening, I threw ksm()s in a couple of places because I figured it might help.

Settings:

KSM on product page:

Product page with notification:

After changing quantity to 500 on the product page, clicking "add to cart", waiting for page refresh, and then hitting the cart menu item:

Changed the quantity to 499 (the step is 250-700 so it shouldn't matter), clicked "update cart", and then the price and total updated:

It's very strange, I think I did something wrong somewhere.

So this is how I ended up fixing it, it's hacky, but it works:

Inside of commerce_xquantity/src/plugin/views/field/xquantityeditquantity.php

  public function viewsForm(array &$form, FormStateInterface $form_state) {
    parent::viewsForm($form, $form_state);
    $form_object = $form_state->getFormObject();

    foreach ($this->view->result as $row_index => $row) {
      /** @var \Drupal\commerce_order\Entity\OrderItemInterface $order_item */
      $order_item = $this->getEntity($row);
      $default_value = $order_item->getQuantity() + 0;

      $settings = $order_item->setQuantityPrices($form_object, $this, $form_state);


      /* Custom */
      $order_storage = $this->entityTypeManager->getStorage('commerce_order');
      $cart = $order_storage->load($this->view->argument['order_id']->getValue());
      if ($purchased_entity = $order_item->getPurchasedEntity()) {
        if ($price = $order_item->getQuantityPrice($form_object, $purchased_entity, $default_value)) {
          if (!$price->equals($order_item->getUnitPrice())) {
            $order_item->setUnitPrice($price, TRUE);
            $form['#prefix'] = '<div class="views-form force-refresh">';
          }
        }
      }
      $order_item->setQuantity($default_value);
      $this->cartManager->updateOrderItem($cart, $order_item, FALSE);
      $cart->save();
      /* end custom */





      if (is_string($settings['prefix']) && !empty($settings['prefix'])) {
        $prefixes = explode('|', $settings['prefix']);
        $prefix = (count($prefixes) > 1) ? $this->formatPlural($default_value, $prefixes[0], $prefixes[1]) : $prefixes[0];
        $settings['prefix'] = FieldFilteredMarkup::create($prefix);
      }
      if (is_string($settings['suffix']) && !empty($settings['suffix'])) {
        $suffixes = explode('|', $settings['suffix']);
        $suffix = (count($suffixes) > 1) ? $this->formatPlural($default_value, $suffixes[0], $suffixes[1]) : $suffixes[0];
        $settings['suffix'] = FieldFilteredMarkup::create($suffix);
      }

      $form[$this->options['id']][$row_index] = [
        '#type' => 'number',
        '#title' => $this->t('Quantity'),
        '#title_display' => 'invisible',
        '#default_value' => $default_value,
        '#size' => 4,
        '#min' => isset($settings['min']) && is_numeric($settings['min']) ? $settings['min'] : '1',
        '#max' => isset($settings['max']) && is_numeric($settings['max']) ? $settings['max'] : '9999',
        '#step' => isset($settings['step']) && is_numeric($settings['step']) ? $settings['step'] : '1',
        '#placeholder' => empty($settings['placeholder']) ? '' : $settings['placeholder'],
        '#field_prefix' => $settings['prefix'],
        '#field_suffix' => $settings['suffix'],
        // Might be disabled on the quantity field form display widget.
        '#disabled' => isset($settings['disable_on_cart']) ? $settings['disable_on_cart'] : FALSE,
      ];

      
    }
  }

and then I just do this inside my js:

if ($('.views-form').hasClass('force-refresh')) {
window.location.reload();
}

@drugan

Thanks! I took most of the code from viewsformsubmit() lol, as I noticed that when I updated the quantity on cart and submitted the views form everything would update correctly, so I figured there is something going on in the form submit that isn't being done when the form is being built.

I set end quantities initially because I was worried that if there was no end quantity, it would apply both adjustments to the price, which is kind of silly looking back at it now, but for some reason I figured that would be the default behavior with no end quantity set. I will remove them all.

I did a few more things, got rid of some redundant lines and pulled what I could out of the recursion so that the cart doesn't need to be loaded and saved for each row/product on the cart view, I will include that below.

I do have an unrelated question though, if I have a product, lets say a phone case, and it comes in two colors, and I have one quantity discount set up for a minimum quantity of 10 items. Will the adjustment still trigger if I add 6 of each variation (for a total of 12) to my cart? I am assuming it will not because they are separate order items, but ideally I would actually like it to combine variation quantities before computing whether or not the discount applies. I understand how complex that would be to actually implement though, and then the majority of the community may not even want it to behave in such a way, but it would be nice as a feature you could enable with a checkbox or something in a future version.

Anyways, here is the final code, thank you for your help. It still requires JS to force the refresh as I do not know how to force the views form to rebuild programmatically, if that is even something that can be done. Anywhere I added code I put /* Custom - explanation */, there are 3 snippets I added.

public function viewsForm(array &$form, FormStateInterface $form_state) {
    parent::viewsForm($form, $form_state);
    $form_object = $form_state->getFormObject();


    /* custom 1  - load cart to update for quantity */

    $order_storage = $this->entityTypeManager->getStorage('commerce_order');
    $cart = $order_storage->load($this->view->argument['order_id']->getValue());
    $priceUpdated = false;

    /* end custom 1 */




    foreach ($this->view->result as $row_index => $row) {
      /** @var \Drupal\commerce_order\Entity\OrderItemInterface $order_item */
      $order_item = $this->getEntity($row);
      $default_value = $order_item->getQuantity() + 0;

      $settings = $order_item->setQuantityPrices($form_object, $this, $form_state);


     


      /* Custom 2 - check each order item to see if price is correct for quantity, if not update it */
      
      if ($purchased_entity = $order_item->getPurchasedEntity()) {
        if ($price = $order_item->getQuantityPrice($form_object, $purchased_entity, $default_value)) {
          if (!$price->equals($order_item->getUnitPrice())) {
            $order_item->setUnitPrice($price, TRUE);
            $this->cartManager->updateOrderItem($cart, $order_item, FALSE);
            $priceUpdated = true;
          }
        }
      }

      /* end custom 2 */





      if (is_string($settings['prefix']) && !empty($settings['prefix'])) {
        $prefixes = explode('|', $settings['prefix']);
        $prefix = (count($prefixes) > 1) ? $this->formatPlural($default_value, $prefixes[0], $prefixes[1]) : $prefixes[0];
        $settings['prefix'] = FieldFilteredMarkup::create($prefix);
      }
      if (is_string($settings['suffix']) && !empty($settings['suffix'])) {
        $suffixes = explode('|', $settings['suffix']);
        $suffix = (count($suffixes) > 1) ? $this->formatPlural($default_value, $suffixes[0], $suffixes[1]) : $suffixes[0];
        $settings['suffix'] = FieldFilteredMarkup::create($suffix);
      }

      $form[$this->options['id']][$row_index] = [
        '#type' => 'number',
        '#title' => $this->t('Quantity'),
        '#title_display' => 'invisible',
        '#default_value' => $default_value,
        '#size' => 4,
        '#min' => isset($settings['min']) && is_numeric($settings['min']) ? $settings['min'] : '1',
        '#max' => isset($settings['max']) && is_numeric($settings['max']) ? $settings['max'] : '9999',
        '#step' => isset($settings['step']) && is_numeric($settings['step']) ? $settings['step'] : '1',
        '#placeholder' => empty($settings['placeholder']) ? '' : $settings['placeholder'],
        '#field_prefix' => $settings['prefix'],
        '#field_suffix' => $settings['suffix'],
        // Might be disabled on the quantity field form display widget.
        '#disabled' => isset($settings['disable_on_cart']) ? $settings['disable_on_cart'] : FALSE,
      ];

      
    }


    /* custom 3 - save cart and add refresh class for JS if price didn't match quantity */
    if ($priceUpdated) {
      $form['#prefix'] = '<div class="views-form force-refresh">';
      $cart->save();
    }
    /* end custom 3 */


  }