Currently, the module does not support Refund

CommentFileSizeAuthor
#3 Fix_invalid_keys_for_refund_access_rule.patch1.18 KBfpalewacki
#2 Screen Shot 2019-11-21 at 00.08.06.png18.23 KBmatio89
#2 Screen Shot 2019-11-21 at 00.07.57.png29.78 KBmatio89
#2 Screen Shot 2019-11-21 at 00.07.51.png62.43 KBmatio89
#2 Screen Shot 2019-11-21 at 00.07.26.png21.85 KBmatio89
#2 add-refund-commerce-stripe-pi-3079863-2.patch2.79 KBmatio89

Comments

GoZ created an issue. See original summary.

matio89’s picture

matio89 commented
Status: Active » Needs review
StatusFileSize
new add-refund-commerce-stripe-pi-3079863-2.patch2.79 KB
new Screen Shot 2019-11-21 at 00.07.26.png21.85 KB
new Screen Shot 2019-11-21 at 00.07.51.png62.43 KB
new Screen Shot 2019-11-21 at 00.07.57.png29.78 KB
new Screen Shot 2019-11-21 at 00.08.06.png18.23 KB

Hi,
I made necessary changes and the refund works now with payment intent.

Attached the patch & Screenshots.
Thanks.

fpalewacki’s picture

fpalewacki commented
StatusFileSize
new Fix_invalid_keys_for_refund_access_rule.patch1.18 KB

Hi,
thanks for the patch, there is still an error with the access to the refund form - you can access the refund payment and try to issue a refund on it.
I've made a patch to handle it. I've changed the commerce_stripe_pi_return_access
instead of commerce_stripe_pi_refund_form_submit so the rules work with the old payments but maybe the $refund_transaction->data in the submit form should be fixed instead.

  • GoZ committed b172ff8 on 7.x-1.x authored by fpalewacki 
    Issue #3079863 by matio89, fpalewacki: Module does not support Refund
goz’s picture

goz commented
Status: Needs review » Fixed

I commit your changes.

I replace print_r() by json_encode putting data in payload, since json is used everywhere else in the module to store data in payload.

Also fix PaymentIntent call to use full namespace.

Thanks both of you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.