The help text is difficult to read in some cases where the grammar could use some work.

Patch forthcoming.

CommentFileSizeAuthor
#2 node_revision_delete-fix_help_grammar-3079306-2.patch3.6 KBcolan

Comments

colan created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new node_revision_delete-fix_help_grammar-3079306-2.patch3.6 KB
hugovk’s picture

hugovk commented
Status: Needs review » Reviewed & tested by the community

Looks good!

The second one can also be a bit more concise:

-Revisions older than this age will be deleted, ...
-Revisions older than this will be deleted, ...

I was just about to create a similar patch, I'll avoid touching the ones dealt with here.

hugovk’s picture

hugovk commented

(Please see https://www.drupal.org/project/node_revision_delete/issues/3079447 for some additional language fixes.)

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks @colan, as I'm not an English speaker is difficult for me sometimes to write in the correct way. We added new features from the last time the help was updated, can you help us writing the missing help topics?

  • adriancid committed 8975ef9 on 8.x-1.x authored by colan 
    Issue #3079306 by colan, hugovk, adriancid: Improve English grammar in...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

#5: Sure, not a problem. If you can point me to whatever you need help with, I'll take a look. (Or does #3079447: Improve the English grammar in the module strings already fix this?)

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

@colan, the issue #3079447: Improve the English grammar in the module strings don't fix the problem, as we added many features in the last days and we don't have a help text or explanation (in the module help, in the project page and in the README.txt file) about these new features. Even you can help us to finish the module to release the 8.x-1.0 version and if you want you can help to create the Project Documentation Guide, as all the documentation tasks will be related.

On the other hand, you can check the code, write the missing tests (Unit, Kernel, and Functional) if you have some time, I'm trying to do it but this takes me a lot of time and I don't want to release the 8.x-1.0 version without tests as this module can delete some important information from the sites if is not working well.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Right. I'm new to this module, but as I now need it for a client, I'll continue to contribute when I can (including adding documentation that seems to be missing). Please don't wait for me though as I may not be able to make it a priority. Feel free to add text (in English, ou peut-être en français? ;), and I can review as I see it.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

Merci @colan, all the help are welcome.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.