Problem/Motivation

At the moment only one path is supported. It would be useful to add support for multiple paths (indexes).

Proposed resolution

We could add support for multiple paths (indexes) by storing the configuration in the search index instead of in a global settings form.

CommentFileSizeAuthor
#10 search_overrides-settings_labels-3078313-10.patch2.87 KBmandclu
#7 search_overrides-settings_labels-3078313-7.patch1.93 KBmandclu
#6 issue3078313.patch896 bytesbarrett

Comments

mpp created an issue. See original summary.

mandclu’s picture

mandclu commented

Sounds like a great suggestion. If we could get this and #3059864: Allow selecting other entities besides nodes done, I think that would justify an 8.x-2.x release.

mandclu’s picture

mandclu commented

Thinking about this some more, the override should currently apply globally anyway. The path in the global configuration is just for use in the "Test Override" button. Theoretically you could update that to accept multiple values (with labels at that point) and then offer multiple links to test, but it's really just there as a convenience, since all it really does is run a search for the term.

As such, if anything we might consider the opposite: the possible for any override to make it ONLY apply to a subset of the defined indexes. Would that be of value?

barrett’s picture

barrett commented

Mandclu, to confirm, you're saying the path and URL paramer values in the form at `/admin/config/search/search_override/settings`are only used to provide test and preview results for the overrides and do not restrict overrides from being applied at other paths. Correct?

It might be worth adding some text to the form to clarify that, if it is indeed the case. Just looking at the form, I had drawn the same conclusion as @mpp; that the overrides would only take effect at that url.

mandclu’s picture

mandclu commented
Title: Add support for multiple indexes » Clarify settings paths are only for previews
Assigned: Unassigned » mandclu

Perfectly reasonable request. I should be able to get that change made shortly.

barrett’s picture

barrett commented
Status: Active » Needs review
StatusFileSize
new issue3078313.patch896 bytes

Here's a first pass at wording

mandclu’s picture

mandclu commented
StatusFileSize
new search_overrides-settings_labels-3078313-7.patch1.93 KB

Tweaked your wording, and also tried to make this more explicit on the settings fields themselves. Skipped the interdiff since it was almost identical to the patch.

barrett’s picture

barrett commented

Pedantic of me but, since you changed the title of the path field to include 'for Preview', should the title of the parameter field also change? Either way, this looks good to me.

mandclu’s picture

mandclu commented

I will confess, I debated about that myself. The other thing I considered was creating a fieldset called "Result Previews" or similar, and putting the fields in there.

mandclu’s picture

mandclu commented
StatusFileSize
new search_overrides-settings_labels-3078313-10.patch2.87 KB

I decided to explore that approach, and like the way it turned out, though the description text ends up being a little less field-specific.

mandclu’s picture

mandclu commented
Assigned: mandclu » Unassigned

  • mandclu committed 6146749 on 2.0.x 
    Issue #3078313 by mandclu, Barrett: Clarify settings paths are only for...
mandclu’s picture

mandclu commented
Status: Needs review » Fixed

Since we're still at alpha for the new release, decided to go ahead and get this merged in. Feel free to reopen if you think additional tweaks are needed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.