Problem/Motivation

Migrate methods of command `nrd-delete-cron-run` to NodeRevisionDeleteCliService

Proposed resolution

None.

Remaining tasks

Patch to come.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#5 Screen Shot 2019-09-05 at 10.40.37 PM.png125.61 KBrobert ngo
#5 node_revision_delete-nrd-dcr-3078185-5-8.x.patch1.35 KBrobert ngo

Comments

Robert Ngo created an issue. See original summary.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Title: Port `nrd-delete-cron-run` command » Port the 'nrd-delete-cron-run drush command
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Title: Port the 'nrd-delete-cron-run drush command » Port the nrd-delete-cron-run drush command
robert ngo’s picture

robert ngo
Location Montreal ⚜️
commented
Assigned: Unassigned » robert ngo
robert ngo’s picture

robert ngo
Location Montreal ⚜️
commented
StatusFileSize
new node_revision_delete-nrd-dcr-3078185-5-8.x.patch1.35 KB
new Screen Shot 2019-09-05 at 10.40.37 PM.png125.61 KB

Patch for porting the command `drush nrd-dcr` into Drush 9.

Note: I think it doesn't make much sense to have a CLI service anymore. That's why this drush command execution code stays in `NodeRevisionDeleteCommands.php`. I think about doing some code refactoring soon, bring other commands back to `NodeRevisionDeleteCommands.php`, then remove the CLI service.
What do you think?

robert ngo’s picture

robert ngo
Location Montreal ⚜️
commented
Status: Active » Needs review

  • adriancid committed 80c6eaa on 8.x-1.x authored by Robert Ngo 
    Issue #3078185 by Robert Ngo, adriancid: Port the nrd-delete-cron-run...
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.