CommentFileSizeAuthor
#8 3078101-8-allow-inheritance.patch1.89 KBchristianadamski
#6 3078101-6-allow-inheritance.patch1.89 KBchristianadamski
#3 geolocation-3078101-2.patch1.18 KBles lim

Comments

Les Lim created an issue. See original summary.

les lim’s picture

les lim
he/they
Primary language English
commented

The ProximityField handler checks for the existence of a ProximityFilter on the view by looking for the a particular Plugin ID. That doesn't work out if we're using a custom handler that extends the ProximityFilter plugin.

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new geolocation-3078101-2.patch1.18 KB

Patch attached, which replaces the plugin ID-based string check with a "is_a()" call on the class type.

Status: Needs review » Needs work

The last submitted patch, 3: geolocation-3078101-2.patch, failed testing. View results

christianadamski’s picture

christianadamski commented

Could I kindly ask you to extend your patch to also include the same fix for ProximityFilter as well?

christianadamski’s picture

christianadamski commented
Status: Needs work » Needs review
StatusFileSize
new 3078101-6-allow-inheritance.patch1.89 KB

Ok, that was a single line. Changed it myself.

christianadamski’s picture

christianadamski commented

And I just notice that your second check is wrong.

christianadamski’s picture

christianadamski commented
StatusFileSize
new 3078101-8-allow-inheritance.patch1.89 KB

Fixed patch

  • ChristianAdamski authored d82da19 on 8.x-1.x 
    Issue #3078101 by ChristianAdamski, Les Lim: ProximityField fails if...
christianadamski’s picture

christianadamski commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.