Problem/Motivation

From #3031379: Add a new test type to do real update testing


/**
 * Extend the Mink client for Drupal use-cases.
 *
 * This is adapted from https://github.com/symfony/symfony/pull/27118.
 *
 * @todo Update this client when Drupal starts using Symfony 4.2.0+.
 */
class DrupalMinkClient extends Client {

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3077785.patch9.09 KBlongwave

Comments

heddn created an issue. See original summary.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Postponed » Needs review
StatusFileSize
new 3077785.patch9.09 KB

We can just refactor this class away entirely, as far as I can see this will never be used any more.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Update DrupalMinkClient after Symfon 4.2+ » Refactor away DrupalMinkClient after Symfony 4.2+
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: » #3136002: [meta] Remove compatibility shims for Symfony 4.3 and earlier
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

#4 looks great, 184 deletions and 1 insertion :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

This does indeed look great. I think this safe to remove - it's extremely low level test code that is not even running apart from with the test and it's part of build tests which are relatively new. Also the code is only autoloadable during tests so removing it will not break any Drupal site at runtime. However I still think given we're removing a class we should have a CR just in case. Note I can find no contrib usages and even Drupal Test Traits doesn't use this.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
Issue tags: -Needs change record

Draft change record: https://www.drupal.org/node/3155460

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the change record.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 4babf62 and pushed to 9.1.x. Thanks!

  • alexpott committed 4babf62 on 9.1.x 
    Issue #3077785 by longwave: Refactor away DrupalMinkClient after Symfony...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.