Any time we update our database config_split entry with new graylisted or blacklisted items, we have to also update our config_readonly exceptions. It would be nice if these two modules could work together using hook_config_readonly_whitelist_patterns().

Comments

Dave Reid created an issue. See original summary.

dave reid’s picture

Status: Active » Needs review
StatusFileSize
new793 bytes

Patch adds an implementation of hook_config_readonly_whitelist_patterns().

bircher’s picture

Status: Needs review » Needs work

I am very interested in adding this feature. (I helped with adding the hook after all)
I am also inclined to just commit it, however, I have a doubt.
I think this only works with splits that are by default enabled. (ie it does not check for the configuration overrides)
We recommend to control the split being active in settings.php, so I think we should make sure we use that here too.

dave reid’s picture

I've tested this and the loadByProperties() does actually work with settings.php activated-or-deactived config splits as expected. The method inspects the config entities that includes overrides as I understand it.

dave reid’s picture

Status: Needs work » Needs review

  • bircher committed 23ca721 on 8.x-1.x
    Issue #3077437 by Dave Reid: Support database split gray/blacklisted...
bircher’s picture

Status: Needs review » Fixed

Great! Thanks for the contribution!

  • bircher committed 23ca721 on 2.0.x
    Issue #3077437 by Dave Reid: Support database split gray/blacklisted...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.