Problem/Motivation

Right now, if a fatal error or an exception occurs while performing an ImageToolkitOperation, we get WSOD as these events are not captured by ImageToolkitBase::apply.

This was already discovered in #2583041: GD toolkit & operations should catch \Throwable to fail gracefully in case of errors.

Proposed resolution

In 8.8.x where we only support PHP 7+, we can catch a \Throwable that will cover all cases not managed.

Remaining tasks

Review

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

CommentFileSizeAuthor
#2 3077376-2.patch3.02 KBmondrake
#2 3077376-2-test-only.patch2.45 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

StatusFileSize
new2.45 KB
new3.02 KB

Test only and full patches.

mondrake’s picture

Status: Active » Needs review
mondrake’s picture

Title: ImageToolkitBase::apply should catch \Throwable to avoid WSOD-leading events » ImageToolkitBase::apply should catch \Throwable to manage WSOD-leading events

The last submitted patch, 2: 3077376-2-test-only.patch, failed testing. View results

mondrake’s picture

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

mondrake’s picture

Status: Needs review » Closed (duplicate)