Closed (fixed)
Project:
Editor Notes
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
24 Aug 2019 at 15:59 UTC
Updated:
14 Oct 2022 at 13:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Rostislav Sergeenkov commentedBug report was transformed to feature request "Implement token support".
Comment #3
Rostislav Sergeenkov commentedComment #4
promo-il commented+1 PHP:7.1 D:8.8.5
Comment #5
codesmithI wa able to remove the warning by changing the following code in src/Plugin/FieldType/EditorNoteItem.php in the propertyDefinitions() function
Change:
$properties['value'] = DataDefinition::create('string');To:
$properties['value'] = DataDefinition::create('string')->setLabel(t('Editor Note'));I can make a patch if requested.
Comment #6
driverok commentedHi.
Thanks for using this module.
Unfortunately, I wasn't able to reproduce the issue.
For now, the module is not supporting any tokens.
If the tokens are required, please provide more information about the use case.
Until that, postponing the issue.
Comment #7
duckydan commentedI am seeing this as well.
Comment #8
System Lord commentedSame issue here.
D939
Might be an issue with the themes. I'm using core bartik and the form doesn't appear on the content type, but it does appear when on Seven (for admin). The table of notes appears on bartik after the Admin enters a note, but again, no form for the editor/author to post.
Permission are set for authenticated users.
No custom field settings (ie other module preferences).
Comment #9
delty commentedHaving the same issue here. I know it's not hurting the site in any way, I just like to see a clean status report. Maybe @codesmith can roll a patch?
Comment #10
katekuratsu commentedGot the same error on 9.4.3. This patch works for me.
Comment #11
driverok commentedThanks everyone, the fix is merged