Description

This simple module allow to see module path (location) on module list page. It is useful for developers who maintain old (legacy) projects with wrong module locations, and for multisite installations.

Project link

https://www.drupal.org/project/module_locator

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/module_locator.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-module_locator...

CommentFileSizeAuthor
module-locator.png64.99 KBandrew answer

Comments

Andrew Answer created an issue. See original summary.

phthlaap’s picture

phthlaap commented
Status: Needs review » Needs work

Thanks for your apply.

Please help to fix issues reported by PAReview:

1.

Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing.

2.

FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/module_locator.module
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------
  24 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
  39 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: ]
 118 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
 120 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 583ms; Memory: 4Mb
phthlaap’s picture

phthlaap commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

Thank you for applying! I added the Git instructions for non-maintainer users.

andrew answer’s picture

andrew answer commented
Status: Needs work » Needs review

Code style and documentation fixed, please check.

phthlaap’s picture

phthlaap commented
Status: Needs review » Reviewed & tested by the community

Thank you for the contribution!

I have not found any security related issues in the code.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.