Capitalize the name of the module, because module names are proper nouns.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#6 interdiff_2-6.txt211 bytesrithesh bk
#6 3076904-6.patch441 bytesrithesh bk
#2 digital_size_formatter-info-3076904-2.patch405 bytesalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new digital_size_formatter-info-3076904-2.patch405 bytes
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Needs work

Thank you. As we are already touching this file, let's replace the core: line with the new core_version_requirement: ^8 || ^ 9

rithesh bk’s picture

rithesh bk commented
Assigned: Unassigned » rithesh bk
Issue tags: +VbContribution2020

currently working on it .....

salah1’s picture

salah1
Location VA, U.S
commented

Great. I came here to upload the patch and see you on it.
I just double checked that there are no issues with respect to : https://www.drupal.org/node/3070687
So, go for it.

rithesh bk’s picture

rithesh bk commented
Assigned: rithesh bk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3076904-6.patch441 bytes
new interdiff_2-6.txt211 bytes

Please find the updated patch and interdiff file

salah1’s picture

salah1
Location VA, U.S
commented

This looks good.
I also run drupal-check against the module to make sure there is no "deprecated code" that will interfere with the
core_version_requirement: ^8 || ^9

As stated, in https://www.drupal.org/node/3070687

Most modules however will have to remove deprecated code to be compatible with Drupal 9. Therefore they will not able to be compatible with all versions of Drupal 8.

.
So, hope this gets committed soon. Last review took 6 months :)

salah1’s picture

salah1
Location VA, U.S
commented
Status: Needs review » Reviewed & tested by the community
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Version: 8.x-1.x-dev » 2.0.x-dev
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Reviewed & tested by the community » Closed (won't fix)

No more relevant