Closed (fixed)
Project:
Login Popup
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Aug 2019 at 08:09 UTC
Updated:
1 Aug 2020 at 08:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
patelmayank7552 commentedComment #3
patelmayank7552 commentedHi,
I have fixed the coding standard for this module.
PFA:
screenshot.png
coding-standard-patch-fix-3076740-3.patch
Comment #4
patelmayank7552 commentedComment #5
xaiwant commentedHi @patelmayank7552 marking this resolve. as i don't see any issue in code report
Comment #6
jaykandariComment #7
jaykandariComment #8
rohittiwari commentedSteps to test the patch provided above https://www.drupal.org/files/issues/2019-08-23/coding-standard-patch-fix...
1. installed and configured phpcs for drupal using documentation https://www.drupal.org/docs/contributed-modules/code-review-module/insta...
2. ran the code phpcs --standard=Drupal,DrupalPractice . and received
3. applied patch using cmd
4. ran and tested the patch with following output
5. So patch works as expected.
Comment #11
jaykandariComment #12
jaykandariThanks all for contributing.
Merged & Pushed to 2.x branch.
Comment #14
jaykandariComment #16
jaykandariComment #18
jaykandari