When checking the code I found some soon to be deprecated drupal_set_message usage. I will be adding a patch right away.

CommentFileSizeAuthor
#12 interdiff_10-12.txt3.3 KBbcizej
#12 3076569-12.patch10.17 KBbcizej
#10 3076569-10.patch9.63 KBnace_fr
3076569-6.patch9.63 KBnace_fr
#6 3076569-6.patch9.63 KBnace_fr
#3 3076569-3.patch3.67 KBstrozx
#2 replace_the_soon_to_be_deprecated_drupal_set_message_functions-3076569-2.patch1.62 KBmarko.romsak

Comments

marko.romsak created an issue. See original summary.

marko.romsak’s picture

marko.romsak commented
StatusFileSize
new replace_the_soon_to_be_deprecated_drupal_set_message_functions-3076569-2.patch1.62 KB

Deprecated drupal_set_message usage replaced.

strozx’s picture

strozx commented
StatusFileSize
new 3076569-3.patch3.67 KB

Applied the patch but saw that there is still some drupal_set_message code in there. So I created a new patch

nace_fr’s picture

nace_fr commented
Status: Needs review » Reviewed & tested by the community

Checked the patch from #3 and all the deprecated drupal_set_message code is replaced. I'm changing status to "Reviewed".

nace_fr’s picture

nace_fr commented
Status: Reviewed & tested by the community » Needs work

I was too fast with the status change. Dependency injection needs to be added. Changing status to "Needs work".

nace_fr’s picture

nace_fr commented
Status: Needs work » Needs review
StatusFileSize
new 3076569-6.patch9.63 KB

DI is also added now.

strozx’s picture

strozx commented
Status: Needs review » Reviewed & tested by the community

Thanks, Nace for updating the patch with dependency injection

strozx’s picture

strozx commented
nace_fr’s picture

nace_fr commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3076569-10.patch9.63 KB

I have added now DI also.

strozx’s picture

strozx commented
Status: Needs review » Reviewed & tested by the community

Thanks, Nace this works!

bcizej’s picture

bcizej commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3076569-12.patch10.17 KB
new interdiff_10-12.txt3.3 KB

I reviewed the patch and the message types are wrong. Here is a patch that corrects the problems.

boshtian’s picture

boshtian commented
Status: Needs review » Reviewed & tested by the community

Patch applies and fixes all the issues mentioned in description.

  • benjamincizej committed f3b51ba on 8.x-2.x 
    Issue #3076569 by nace_fric, benjamincizej, strozx, marko.romsak,...
bcizej’s picture

bcizej commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.