It might be nice to be able to pick which derivative is used for the thumbnail field.

CommentFileSizeAuthor
#8 3076163-thumbnail-configurable-derivative-with-fallback.patch4.26 KBjarnetb
#7 3076163-thumbnail-configurable-derivative-2.patch4.25 KBjarnetb
#6 3076163-thumbnail-configurable-derivative.patch3.31 KBjarnetb
#5 3076163-thumbnail-configurable-derivative.patch5.42 KBdave reid
#2 3076163-thumbnail-configurable-derivative.patch4.47 KBdave reid

Issue fork bynder-3076163

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Dave Reid created an issue. See original summary.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 3076163-thumbnail-configurable-derivative.patch4.47 KB

This adds configuration to the media type to make this selectable.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

This needs a reroll now that #3052945: Bynder asset copied to Drupal file system is committed.

I don't really get the last change with the brands method call?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Also, there is now a BynderApi::getDerivatives() method that you might be able to use here?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3076163-thumbnail-configurable-derivative.patch5.42 KB

I don't really get the last change with the brands method call?

The getBrands() call was just used to test API connectivity. Since we're now using $this->bynderApi->getDerivatives() to fetch data from the API, it serves the same purpose.

Re-rolled for 8.x-2.x.

jarnetb’s picture

jarnetb commented
StatusFileSize
new 3076163-thumbnail-configurable-derivative.patch3.31 KB

Removed BynderSearch.php changes from previous patch since this breaks the Bynder Search in Entity browser. Needs to be "thul" right here instead of chosen thumbnail image.

jarnetb’s picture

jarnetb commented
StatusFileSize
new 3076163-thumbnail-configurable-derivative-2.patch4.25 KB

Uploaded wrong patch file in previous comment

jarnetb’s picture

jarnetb commented
StatusFileSize
new 3076163-thumbnail-configurable-derivative-with-fallback.patch4.26 KB

Added an extra fallback when the chosen derivative does not exist for selected image. Falls back to original 'webimage' derivative.

primsi made their first commit to this issue’s fork.

primsi changed the visibility of the branch 3076163-make-the-thumbnail to hidden.

primsi opened merge request !57

primsi’s picture

primsi commented

Sorry for the branch confusion, I created the first one from the wrong branch.

primsi’s picture

primsi commented

I closed #3589018: Bynder Thumbnail without extension and updated issue credits here.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Make the thumbnail derivative configurable » Make the thumbnail derivative configurable and ensure it has a file extension
primsi’s picture

primsi commented
Status: Needs work » Needs review

  • berdir committed 3e54e854 on 4.x authored by primsi 
    feat: #3076163 Make the thumbnail derivative configurable and ensure it...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Merged. This should significantly improve the flexibility of the thumbnail and avoid multiple bugs. We will also work on another change to support updating the thumbnail if the remote asset changed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • berdir committed e212cf99 on 4.x 
    fix #3076163: Limit thumbnail length to 250 characters to account for...