Project link

https://www.drupal.org/project/login_switch

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/login_switch.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-login_switch.git

Comments

DrupalMattS created an issue. See original summary.

phthlaap’s picture

Status: Needs review » Needs work

Hello,
Thank you for the contribution!

Please fix the following issues:
(1.) Make the default Git branch to be '8.x-1.x'.

(2.) Please fix the following issues reported by PAReview:

FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Routing/RouteSubscriber.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 21 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
--------------------------------------------------------------------------

(3.) Please fix the following issues reported by drupal-check:

 ------ ------------------------------------------------------------------------------
  Line   src\Routing\DynamicRoute.php
 ------ ------------------------------------------------------------------------------
  17     \Drupal calls should be avoided in classes, use dependency injection instead
  18     \Drupal calls should be avoided in classes, use dependency injection instead
 ------ ------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------
  Line   src\Routing\RouteSubscriber.php
 ------ ----------------------------------------------------------------------------------------
  21     Call to static method config() on an unknown class Drupal\login_switch\Routing\Drupal.
 ------ ----------------------------------------------------------------------------------------


 [ERROR] Found 3 errors
phthlaap’s picture

Issue summary: View changes
drupalmatts’s picture

How do i change the default branch in GitLab? The code updates have been completed.

drupalmatts’s picture

Status: Needs work » Needs review

OK default branch is also updated.

vuil’s picture

Issue summary: View changes
vuil’s picture

Status: Needs review » Needs work

Thank you for the contribution!

Please replace the \Drupal::xxx usage with Dependency injection (DI).

FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Routing/RouteSubscriber.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 21 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
--------------------------------------------------------------------------
drupalmatts’s picture

Status: Needs work » Needs review

The dev branch is no longer showing any errors. All \Drupal references have been converted and no code sniffer issues. Please confirm.

avpaderno’s picture

Issue summary: View changes

Thank you for applying! I added the Git instructions for non-maintainer users. Reviewers will check the project and post comments to list what should be changed.

@branch is a wrong branch name. That branch should be removed.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.