Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
15 Aug 2019 at 22:36 UTC
Updated:
30 Aug 2019 at 19:39 UTC
Jump to comment: Most recent
Comments
Comment #2
phthlaap commentedHello,
Thank you for the contribution!
Please fix the following issues:
(1.) Make the default Git branch to be '8.x-1.x'.
(2.) Please fix the following issues reported by PAReview:
(3.) Please fix the following issues reported by drupal-check:
Comment #3
phthlaap commentedComment #4
drupalmatts commentedHow do i change the default branch in GitLab? The code updates have been completed.
Comment #5
drupalmatts commentedOK default branch is also updated.
Comment #6
vuilComment #7
vuilThank you for the contribution!
Please replace the \Drupal::xxx usage with Dependency injection (DI).
Comment #8
drupalmatts commentedThe dev branch is no longer showing any errors. All \Drupal references have been converted and no code sniffer issues. Please confirm.
Comment #9
avpadernoThank you for applying! I added the Git instructions for non-maintainer users. Reviewers will check the project and post comments to list what should be changed.
@branch is a wrong branch name. That branch should be removed.
Comment #10
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.