hook name should be as module name to prevent name classes if similar module is installed. Using "detect_mobile" as hook instead of "mobile_detect_twig_extensions".

CommentFileSizeAuthor
#7 change_to_drupa_standard.patch133.39 KBuditrawat
#3 hook-namespace-naming-convention-3074818-3.patch2.23 KBsarathkm

Comments

sarathkm created an issue. See original summary.

sarathkm’s picture

sarathkm
Sapiens
Primary language English
Location Bengaluru, Karnataka
commented
Title: HOOK naming convention not followed » HOOK/Namespace naming convention not followed
Issue tags: +Namespace
sarathkm’s picture

sarathkm
Sapiens
Primary language English
Location Bengaluru, Karnataka
commented
StatusFileSize
new hook-namespace-naming-convention-3074818-3.patch2.23 KB
sarathkm’s picture

sarathkm
Sapiens
Primary language English
Location Bengaluru, Karnataka
commented
Status: Active » Needs review
mahipal46’s picture

mahipal46 commented
Assigned: Unassigned » mahipal46
mahipal46’s picture

mahipal46 commented
Assigned: mahipal46 » Unassigned
Status: Needs review » Reviewed & tested by the community

Patch looks good to me working as Expected.

uditrawat’s picture

uditrawat
Primary language English
commented
Priority: Normal » Critical
Status: Reviewed & tested by the community » Active
Issue tags: +depricated
StatusFileSize
new change_to_drupa_standard.patch133.39 KB

There are still lots of improvement exist in the module.
Below patch include
1. Fix code spacing according to https://www.drupal.org/docs/develop/standards/coding-standards
2. Remove deprecated function Twig_Function_Function
3. Namespace changes.

nonom’s picture

nonom commented

I'm sorry i was renaming the module didn't committed the right release.

I'm fixing that issues and commiting your patch.

Really thanks for contributing!

  • nonom committed 6414fd5 on 8.x-1.x authored by uditrawat 
    Issue #3074818 by sarathkm, uditrawat, mahipal46: HOOK/Namespace naming...
nonom’s picture

nonom commented
Assigned: Unassigned » nonom
Issue tags: -depricated +deprecated
nonom’s picture

nonom commented
Status: Active » Needs review
nonom’s picture

nonom commented
Status: Needs review » Fixed
nonom’s picture

nonom commented
Status: Fixed » Closed (fixed)
nonom’s picture

nonom commented
Status: Closed (fixed) » Fixed
nonom’s picture

nonom commented
Status: Fixed » Closed (fixed)